LVGL embedded GUI library #603

rleh · 2021-04-01T23:34:11Z

Add LVGL as submodule
LVGL debug-log integration into modm logging
Example for STM32F469-Disco board
- Cleanup
- Use touchscreen in this example
Example for Ili9341 ~~and/or SSD1306 displays~~

rleh · 2021-04-03T16:36:44Z

CI: Error generating documentation for device hosted-linux: 'NoneType' object is not subscriptable

salkinium

I'll test in hardware and check why the docs generator is broken (yet again).

examples/nucleo_l452re/lvgl/main.cpp

ext/lvgl/lvgl.lb

ext/lvgl/lv_conf.h.in

salkinium · 2021-04-03T19:25:30Z

I enabled DMA2D for the STM32 devices that have it. I don't see any visual difference in performance, but maybe it helps elsewhere.

chris-durand

Nice!

src/modm/driver/display/ili9341_impl.hpp

ext/lvgl/lvgl.lb

rleh · 2021-04-04T16:40:32Z

I enabled DMA2D for the STM32 devices that have it. I don't see any visual difference in performance, but maybe it helps elsewhere.

I have not enabled this on purpose and will disable it again because the user has to take care of configuring DMA2D/PXP manually and implementing gpu_fill_cb/gpu_blend_cb. If someone does that he can also enable DMA2D/PXP manually using lv_conf_user.h.

DMA2D would have to become a configurable option in any case, since it could possibly be used by a display driver as well.

ext/lvgl/lv_modm_logging.cpp

ext/lvgl/lvgl.lb

tools/build_script_generator/scons/resources/SConstruct.in

tools/build_script_generator/make/resources/config.mk.in

examples/stm32f469_discovery/lvgl/main.cpp

salkinium

Perfect!

salkinium · 2021-04-05T02:56:51Z

ext/lvgl/lvgl.lb

+
+- https://lvgl.io/
+- https://github.com/lvgl/lvgl
+"""


Ah, we should mention the lv_conf_local.h mechanism, I'll add a fixup commit in a second.

Hm, there's a file called lv_conf_internal.h that contains a lot of defaults.

We should also implement LV_TICK_CUSTOM_SYS_TIME_EXPR to use modm::Clock::now to remove the need for a manual call to lv_tick_inc().

Ok, I've implemented and tested LV_TICK_CUSTOM_SYS_TIME_EXPR.

The only other thing I found interesting in terms of a modm port was LV_ATTRIBUTE_FAST_MEM which we could set to __attribute__((sections(".fastcode"))). However, 15-20kB of RAM seems like a lot and would probably cause issues if set by default. So I didn't.

/* Prefix performance critical functions to place them into a faster memory (e.g RAM) * Uses 15-20 kB extra memory */ #define LV_ATTRIBUTE_FAST_MEM

salkinium · 2021-04-05T04:38:33Z

Ok, I've played around with the lv_conf.h. The lv_conf_internal.h defines default values for the entire config, so I've removed all definitions (and typedefs) from lv_conf.h that we did not change and moved the lv_conf_local.h before our config. There are two reasons for this:

It removes the need for #undef since we're not double declaring the config. This is a very nice UX improvement.
It makes it easier for us to upgrade LVGL in the future, since we only need to worry about the configs that we've changed, not all configs.

Is this config approach ok for you?

salkinium · 2021-04-05T05:38:11Z

(Sorry about the fixup! mess, I'll happily squash this all together if you want).

rleh · 2021-04-05T11:50:27Z

Ok, I've played around with the lv_conf.h. The lv_conf_internal.h defines default values for the entire config, so I've removed all definitions (and typedefs) from lv_conf.h that we did not change and moved the lv_conf_local.h before our config. There are two reasons for this:
1. It removes the need for `#undef` since we're not double declaring the config. This is a very nice UX improvement.

2. It makes it easier for us to upgrade LVGL in the future, since we only need to worry about the configs that we've changed, not _all_ configs.
Is this config approach ok for you?

Very nice, I like this approach. Thanks!

I built this PR on my attempts from >1 year ago with LittlevGL v5/v6, back then lv_conf_internal.h didn't exist as far as I remember; instead lv_conf.h was checked for completeness using lv_conf_checker.h.

rleh · 2021-04-05T11:53:13Z

ext/lvgl/lv_conf.h.in

+/*====================
+   Graphical settings
+ *====================*/
+
+/* Maximal horizontal and vertical resolution to support by the library.*/
+#define LV_HOR_RES_MAX          ({{ options.resolution_horizontal_max }})
+#define LV_VER_RES_MAX          ({{ options.resolution_vertical_max }})
+
+/* Color depth:
+ * - 1:  1 byte per pixel
+ * - 8:  RGB332
+ * - 16: RGB565
+ * - 32: ARGB8888
+ */
+#define LV_COLOR_DEPTH     {{ options.color_depth }}
+
+/* Enable anti-aliasing (lines, and radiuses will be smoothed) */
+#ifndef LV_ANTIALIAS
+#define LV_ANTIALIAS        0
+#endif
+
+/* Dot Per Inch: used to initialize default sizes.
+ * E.g. a button with width = LV_DPI / 2 -> half inch wide
+ * (Not so important, you can adjust it to modify default sizes and spaces)*/
+#define LV_DPI              {{ options.dpi }}     /*[px]*/
+
+/* Type of coordinates. Should be `int16_t` (or `int32_t` for extreme cases) */
+typedef int16_t lv_coord_t;
+
+/*=========================
+   Memory manager settings
+ *=========================*/
+
+/* 1: use custom malloc/free, 0: use the built-in `lv_mem_alloc` and `lv_mem_free` */
+#define LV_MEM_CUSTOM      1
+
+/*==================
+ * Feature usage
+ *==================*/
+
+/* 1: Enable GPU interface*/
+#ifndef LV_USE_GPU
+#define LV_USE_GPU              0   /*Only enables `gpu_fill_cb` and `gpu_blend_cb` in the disp. drv- */
+#endif
+
+/* 1: Enable file system (might be required for images */
+#ifndef LV_USE_FILESYSTEM
+#define LV_USE_FILESYSTEM       0
+#endif
+


We could also remove all this lbuild options and instead let the user configure them through <lv_conf_local.h>. What do you think?

Edit: Except for LV_MEM_CUSTOM, and below LV_TICK_CUSTOM* and LV_USE_LOG/LV_LOG_LEVEL.

Yes, I would prefer that since the lbuild options don't add any additional benefits (ie. like other modules being able to query display size). I'll add a few more fixups.

I've moved all config options out of lbuild into lv_conf_local.h incl. logging, since it's weird to have to regenerate modm again just for that one option. I like this solution very much, it's very clean and minimal.

Co-authored-by: Raphael Lehmann <[email protected]>

rleh · 2021-04-06T17:37:33Z

Merge?

TomSaw · 2021-04-14T04:28:41Z

Got my ili9341 on monday.
I'm happy to test LVLG - Thanks @rleh 🌻🌻🌻

salkinium added advanced 🤯 feature 🚧 labels Apr 2, 2021

rleh force-pushed the lvgl branch 3 times, most recently from ef0504a to cd84b7f Compare April 3, 2021 14:09

rleh marked this pull request as ready for review April 3, 2021 14:10

salkinium reviewed Apr 3, 2021

View reviewed changes

examples/nucleo_l452re/lvgl/main.cpp Outdated Show resolved Hide resolved

ext/lvgl/lvgl.lb Outdated Show resolved Hide resolved

ext/lvgl/lvgl.lb Outdated Show resolved Hide resolved

ext/lvgl/lv_conf.h.in Show resolved Hide resolved

chris-durand requested changes Apr 3, 2021

View reviewed changes

src/modm/driver/display/ili9341_impl.hpp Outdated Show resolved Hide resolved

rleh commented Apr 4, 2021

View reviewed changes

ext/lvgl/lvgl.lb Outdated Show resolved Hide resolved

rleh force-pushed the lvgl branch 2 times, most recently from 7c31019 to 1f7845b Compare April 4, 2021 18:40

salkinium reviewed Apr 4, 2021

View reviewed changes

salkinium approved these changes Apr 5, 2021

View reviewed changes

rleh force-pushed the lvgl branch from aa4de05 to ecd176c Compare April 5, 2021 02:45

salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label Apr 5, 2021

salkinium reviewed Apr 5, 2021

View reviewed changes

rleh mentioned this pull request Apr 5, 2021

Add LittevGL Embedded GUI Library #362

Closed

5 tasks

rleh commented Apr 5, 2021

View reviewed changes

salkinium approved these changes Apr 5, 2021

View reviewed changes

rleh and others added 2 commits April 6, 2021 17:41

[driver] Ili9241: Add drawRaw() method

324a3c2

[build] Fix missing local include path

316bfba

rleh force-pushed the lvgl branch from f0c2660 to 66dd0f1 Compare April 6, 2021 15:43

salkinium and others added 2 commits April 6, 2021 17:54

[ext] Add LVGL embedded GUI library

ca61d6a

Co-authored-by: Raphael Lehmann <[email protected]>

[examples] Add LVGL example for F469-Discovery

d2abea5

[examples] Add LVGL example for Nucleo-L452RE with Ili9341

e0d1327

rleh force-pushed the lvgl branch from 66dd0f1 to e0d1327 Compare April 6, 2021 15:54

rleh added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Apr 6, 2021

salkinium merged commit e0d1327 into modm-io:develop Apr 6, 2021

rleh deleted the lvgl branch April 6, 2021 21:04

salkinium added this to the 2021q2 milestone Jun 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LVGL embedded GUI library #603

LVGL embedded GUI library #603

rleh commented Apr 1, 2021 •

edited

Loading

rleh commented Apr 3, 2021

salkinium left a comment

salkinium commented Apr 3, 2021

chris-durand left a comment

rleh commented Apr 4, 2021

salkinium left a comment

salkinium Apr 5, 2021

salkinium Apr 5, 2021

salkinium Apr 5, 2021

salkinium Apr 5, 2021 •

edited

Loading

salkinium commented Apr 5, 2021

salkinium commented Apr 5, 2021

rleh commented Apr 5, 2021

rleh Apr 5, 2021 •

edited

Loading

salkinium Apr 5, 2021

salkinium Apr 5, 2021

rleh commented Apr 6, 2021

TomSaw commented Apr 14, 2021

LVGL embedded GUI library #603

LVGL embedded GUI library #603

Conversation

rleh commented Apr 1, 2021 • edited Loading

rleh commented Apr 3, 2021

salkinium left a comment

Choose a reason for hiding this comment

salkinium commented Apr 3, 2021

chris-durand left a comment

Choose a reason for hiding this comment

rleh commented Apr 4, 2021

salkinium left a comment

Choose a reason for hiding this comment

salkinium Apr 5, 2021

Choose a reason for hiding this comment

salkinium Apr 5, 2021

Choose a reason for hiding this comment

salkinium Apr 5, 2021

Choose a reason for hiding this comment

salkinium Apr 5, 2021 • edited Loading

Choose a reason for hiding this comment

salkinium commented Apr 5, 2021

salkinium commented Apr 5, 2021

rleh commented Apr 5, 2021

rleh Apr 5, 2021 • edited Loading

Choose a reason for hiding this comment

salkinium Apr 5, 2021

Choose a reason for hiding this comment

salkinium Apr 5, 2021

Choose a reason for hiding this comment

rleh commented Apr 6, 2021

TomSaw commented Apr 14, 2021

rleh commented Apr 1, 2021 •

edited

Loading

salkinium Apr 5, 2021 •

edited

Loading

rleh Apr 5, 2021 •

edited

Loading