Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nucleo-L452RE BSP & 2046 Touch driver & minor fixes #600

Merged
merged 7 commits into from
Apr 1, 2021
Merged

Nucleo-L452RE BSP & 2046 Touch driver & minor fixes #600

merged 7 commits into from
Apr 1, 2021

Conversation

rleh
Copy link
Member

@rleh rleh commented Mar 30, 2021

  • Nucleo-L452RE BSP
    • incl. Blink and Graphics-Touch (Ili9341 + TSC2046) examples
  • 2046 Touch driver
  • Make uint8_t* const in SpiMaster*::transfer(rx*, tx*, len)
  • Ili9341: Fix width/height swap in clear() function
  • Example blue-pill/graphics: enabe backlight, so that the display actually displays something

cc @hshose

While creating this PR I noticed the ads7843-driver which should be compatible with the *2046 touchscreen drivers...

@salkinium
Copy link
Member

salkinium commented Mar 30, 2021 •
edited
Loading

While creating this PR I noticed the ads7843-driver which should be compatible with the *2046 touchscreen drivers...

But is it? #503

chris-durand
chris-durand reviewed Mar 30, 2021
View reviewed changes
examples/nucleo_l452re/graphics_touch/main.cpp Outdated Show resolved Hide resolved
src/modm/driver/touch/touch2046.hpp Outdated Show resolved Hide resolved
src/modm/driver/touch/touch2046.hpp Outdated Show resolved Hide resolved
src/modm/driver/touch/touch2046.hpp Outdated Show resolved Hide resolved
src/modm/driver/touch/touch2046.hpp Show resolved Hide resolved
@rleh
Copy link
Member Author

rleh commented Mar 30, 2021

But is it? #503

Interesting...

@rleh rleh force-pushed the feature/touch2046 branch from cb045a9 to 2e45793 Compare March 30, 2021 23:59
@rleh rleh force-pushed the feature/touch2046 branch from 2e45793 to a9e20e0 Compare March 31, 2021 00:07
@rleh rleh force-pushed the feature/touch2046 branch from a9e20e0 to 1cdc77f Compare March 31, 2021 00:26
@rleh
Copy link
Member Author

rleh commented Mar 31, 2021

Proof photo from the hardware test:
grafik

@rleh
Copy link
Member Author

rleh commented Mar 31, 2021

But ETL will not happen in this PR and probably not in the next week.

Might happen faster than expected... https://github.com/modm-ext/etl-partial

@rleh rleh added the ci:hal Triggers the exhaustive HAL compile CI jobs label Mar 31, 2021
salkinium
salkinium reviewed Mar 31, 2021
View reviewed changes
src/modm/driver/touch/touch2046_impl.hpp Show resolved Hide resolved
src/modm/driver/touch/touch2046_impl.hpp Show resolved Hide resolved
examples/nucleo_l452re/graphics_touch/main.cpp Outdated Show resolved Hide resolved
src/modm/driver/touch/touch2046.lb Outdated Show resolved Hide resolved
@rleh rleh force-pushed the feature/touch2046 branch from 1cdc77f to b1e5588 Compare March 31, 2021 13:59
@salkinium salkinium added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Mar 31, 2021
@salkinium salkinium merged commit b1e5588 into modm-io:develop Apr 1, 2021
@rleh rleh deleted the feature/touch2046 branch April 1, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-durand chris-durand chris-durand left review comments

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs example 🔑 feature 🚧 fix 💎
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleh @salkinium @chris-durand