STUSB4500 USB-PD chip driver #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleh
force-pushed
the
feature/driver_stusb4500
branch
from
596d439 to
20e188d
Compare
|
Just tested the module in the Otter Iron with STM32F072 - works as expected. |
salkinium
requested changes
Mar 10, 2021
rleh
force-pushed
the
feature/driver_stusb4500
branch
from
20e188d to
fc79f79
Compare
rleh
force-pushed
the
feature/driver_stusb4500
branch
from
fc79f79 to
1a11b08
Compare
|
MacOS CI is drunk. Why don't we use a Docker image in MacOS? |
ghost
reviewed
Mar 10, 2021
There was a problem hiding this comment.
You wrong about static asserts and arrays . Explain this and read the specifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal but working implementation of a STUSB4500 driver.
Not actually tested on the STM32F072-Disco board, but on real hardware (because STUSB4500 package is too small for jumper wires).
cc @hshose