Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ext] Update all submodules #566

Merged
merged 12 commits into from
Apr 12, 2021
Merged

[ext] Update all submodules #566

merged 12 commits into from
Apr 12, 2021

Conversation

salkinium
Copy link
Member

@salkinium salkinium commented Feb 21, 2021 •
edited
Loading

Let's update the submodules:

  • TinyUSB changes tested in hardware.
    • DFU callback changed, added explicity delay argument to scons|make program-dfu delay={seconds}
    • Midi write24 signature changed, Midi class depends on Audio class
    • Improved partial customizaton support via weakly linked descriptors
  • FatFs changes tested in hardware.
  • Added Petit FatFs module
  • FreeRTOS changes tested in hardware.
  • FreeRTOS-TCP changes tested in hardware.
  • Better configuration management with #ifndef-guarded modm defaults.

cc @rleh @chris-durand

@rleh

This comment has been minimized.

Sign in to view
@salkinium salkinium closed this Mar 30, 2021
@salkinium salkinium reopened this Mar 30, 2021
@salkinium salkinium force-pushed the feature/submodules branch 2 times, most recently from 0bcd4be to 3d8b588 Compare March 30, 2021 04:25
@salkinium
Copy link
Member Author

I changed the update.py scripts for TinyUSB, CMSIS and FreeRTOS to only copy the latest tagged release. This is necessary to not pick some development version that's buggy.

@salkinium salkinium force-pushed the feature/submodules branch 2 times, most recently from b38248a to fca3779 Compare March 30, 2021 06:13
@salkinium salkinium mentioned this pull request Apr 1, 2021
Merged
9 tasks
@salkinium salkinium force-pushed the feature/submodules branch from fca3779 to 5c1a8ad Compare April 3, 2021 08:41
@salkinium
Copy link
Member Author

All partial repositories have been refactored to use GHA and much better commit messages.

@salkinium salkinium force-pushed the feature/submodules branch 3 times, most recently from e579a5f to cdc9a7f Compare April 4, 2021 04:45
@salkinium
Copy link
Member Author

@rleh Would you test the FreeRTOS+TCP example? I don't have an Ethernet-USB adapter around…

@rleh
Copy link
Member

rleh commented Apr 5, 2021

@rleh Would you test the FreeRTOS+TCP example? I don't have an Ethernet-USB adapter around…

Tested with the updated submodules from you branch:

[rleh@rleh-pc ethernet]$ ping 192.168.1.1
PING 192.168.1.1 (192.168.1.1) 56(84) bytes of data.
64 Bytes von 192.168.1.1: icmp_seq=1 ttl=64 Zeit=0.568 ms
64 Bytes von 192.168.1.1: icmp_seq=2 ttl=64 Zeit=0.136 ms
[...]

[rleh@rleh-pc ethernet]$ curl -v 192.168.1.1
*   Trying 192.168.1.1:80...
* Connected to 192.168.1.1 (192.168.1.1) port 80 (#0)
> GET / HTTP/1.1
> Host: 192.168.1.1
> User-Agent: curl/7.69.1
> Accept: */*
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK 
< Content-Type: text/html
< Connection: keep-alive
* no chunk, no close, no size. Assume close to signal end
< 
* Closing connection 0
<html><body><h1>Hello from your STM32!</h1></body></html>

Looks good to me 👍🏽

@salkinium salkinium force-pushed the feature/submodules branch 2 times, most recently from c9df50d to 95e7483 Compare April 6, 2021 02:09
@salkinium
Copy link
Member Author

salkinium commented Apr 6, 2021 •
edited
Loading

I changed the FatFs config to be in line with the LVGL config. I added a Petit FatFs module, but without example (yet).

I will next check what we can do about the FreeRTOS config which I think should also get the same treatment for consistency. (Shouldn't be too difficult).

@salkinium salkinium force-pushed the feature/submodules branch from 95e7483 to af38a9f Compare April 7, 2021 00:36
@salkinium salkinium force-pushed the feature/submodules branch 5 times, most recently from add843e to 769071a Compare April 8, 2021 09:18
@salkinium salkinium requested a review from rleh April 8, 2021 09:18
@salkinium
Copy link
Member Author

This is ready for review and merging.

rleh
rleh reviewed Apr 10, 2021
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏽

ext/aws/freertos_tcp.md Outdated Show resolved Hide resolved
ext/aws/freertos.md Show resolved Hide resolved
@salkinium salkinium force-pushed the feature/submodules branch from 769071a to 1375ff1 Compare April 11, 2021 02:51
@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label Apr 11, 2021
@salkinium salkinium requested a review from rleh April 11, 2021 07:47
@salkinium salkinium merged commit 1375ff1 into modm-io:develop Apr 12, 2021
@rleh rleh mentioned this pull request Apr 13, 2021
Closed
@salkinium salkinium added this to the 2021q2 milestone Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-durand chris-durand chris-durand approved these changes

@rleh rleh rleh approved these changes

Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs enhancement 🌈 process 📊 testing 🧪
Milestone
2021q2
Development

Successfully merging this pull request may close these issues.
3 participants
@salkinium @rleh @chris-durand