[freertos-plus-tcp] Add includes

[strongly-typed]

There is no FreeRTOS plus TCP project yet in there so the code is not covered by the CI.
When adding <module>modm:freertos:tcp</module> the includes are missing

In file included from modm/ext/freertos_plus_tcp/FreeRTOS_DHCP.c:35:
modm/ext/freertos_plus_tcp/include/FreeRTOS_IP.h:138:10: fatal error: pack_struct_start.h: No such file or directory
  138 | #include "pack_struct_start.h"

What would be more elegant way to add the includes? Shall it depend on the compiler (GCC vs clang?) But only GCC is imported from the original source.

By the way, let's bump FreeRTOS module in modm to the current version.

[salkinium]

What would be more elegant way to add the includes?

You could copy the files directly to the local folder. That way they don't spam up the include path.

Shall it depend on the compiler (GCC vs clang?) But only GCC is imported from the original source.

We don't support any other compiler than GCC right now. We'll deal with this when we add LLVM support in the (far) future.

[strongly-typed]

You could copy the files directly to the local folder. That way they don't spam up the include path.

Like so? But I was not able to identify which command copies these files already to portable:

find . -name "pack_struct_start.h"
./modm/ext/freertos_plus_tcp/include/pack_struct_start.h
./modm/ext/freertos_plus_tcp/portable/Compiler/GCC/pack_struct_start.h

[strongly-typed]

How are we dealing with the warnings?

[salkinium]

How are we dealing with the warnings?

Yeah, that's an issue in general. You can attach compiler options to specific files (see :cmsis:dsp module), however, the build system can only translate these to source files, not header files (obviously).

So if you include a FreeRTOS header file in main.cpp for example, you still get the same warnings.

[strongly-typed]

Which warnings shall be fixed? Are these critical?

• taking address of packed member of '' may result in an unaligned pointer value [-Waddress-of-packed-member]
• #pragma warning "ipconfigTCP_MEM_STATS_MAX_ALLOCATION undefined?"

[salkinium]

Which warnings shall be fixed? Are these critical?

I don't know. FreeRTOS is fairly complicated and lacks clear documentation for most things.

[strongly-typed]

I don't know. FreeRTOS is fairly complicated and lacks clear documentation for most things.

modm ➕ FreeRTOS ⏩💘

😎

[salkinium]

Could you cherry-pick the commit from #474 over to here?

[salkinium]

What hardware are you testing this on? I think it would be neat to test this on the Nucleo-144 boards which have an integrated Ethernet port for like ~20€.

I have these lying around:

• Nucleo-F429ZI
• Disco-F746G
• Nucleo-H743ZI (but unsupported by modm)

[strongly-typed]

What hardware are you testing this on?

Not yet testing. Just get the compiler to work and read through Mike's code.

• Nucleo-F429ZI

I also have this board on my desk, but did not hook it up (yet) except for adjusting the example. I just moved the FreeRTOS plus TCP example to Nucleo-F429ZI, which makes more sense.

[salkinium]

I've tested the malloc lock with all allocators in hardware.

[salkinium]

Ready for squash and merge?

[strongly-typed]

RTM