-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a FreeRTOS-Plus-TCP module. #448
Adds a FreeRTOS-Plus-TCP module. #448
Conversation
I also have the require NetworkInterface.c file, but would add that in the PR of the ETH driver. |
Oh, and I have -Werror=format enabled, which let's the build fail. Not sure if I rather remove it from my build or add a patch to fix the line in FreeRTOS TCP. |
You can add a patch file to the freertos-partial repo and make update.py patch it. I do this for modm-devices too. |
Working on it I was thinking to add something like #if defined __has_include
#if __has_include(<FreeRTOSIPConfigLocal.h>)
#include <FreeRTOSIPConfigLocal.h>
#endif
#endif This would allow the user to add additional defines for FreeRTOS TCP. Or maybe better use a collector in the project.xml file? How would that look like and how to get them into FreeRTOSIPConfig.h? |
What is needed to get this checks pass? |
You can run the test locally: |
I know. But since that is the result of another pull request, how do I get it into this one? Update the submodule and commit? |
Yes, you have to update and commit the submodule |
It shows my private repository master branch and I cannot get it changed. Help!!! |
aa37354
to
7e7ac6f
Compare
I've squashed your commits.
This is great idea, so I added this to both configs. Please check if this works for you, then I'd like to merge this PR. (lbuild collectors are only useful when additional side-effects from modm are required, for example, the build system flags are reformatted into the specific build systems. For this, it's completely overkill, your solution is way better.) |
Is it ok to assume that the compile has the __has_include() function? What if not? |
Yes, it's part of C++17 and both GCC and LLVM have it implemented. |
7e7ac6f
to
821677b
Compare
I've removed the options and added some documentation, does this work for you? |
Now a test is failing, what is wrong? |
The arm-eabi-gcc download link isn't working in the CI. It's working for me locally, so I'm just going to ignore it for now. |
(The macOS CI is not part of the required tests, since it has been proven a bit unreliable.) |
Fixes part of #447.