Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver for Sx1276 LoRa modem #418

Merged
merged 2 commits into from
Jun 13, 2020
Merged

Conversation

nesos
Copy link
Contributor

@nesos nesos commented Jun 12, 2020

This is a basic driver for the Semtech Sx1276 LoRa modem chip.

The datasheet can be found here: https://semtech.my.salesforce.com/sfc/p/#E0000000JelG/a/2R0000001OKs/Bs97dmPXeatnbdoJNVMIDaKDlQz8q1N_gxDcgqi7g2o

Currently it only supports the LoRa modulation of the chip (the chip itself got a FSK modulation mode as well), and only the 443Mhz Band can be used.

I added two examples to the driver demonstrating the TX and RX mode of the driver. The example runs on two Nucleo F411 with the SX1276 mbed shield (https://os.mbed.com/components/SX1276MB1xAS/)

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A beautiful driver!

Could you convert the spaces to tabs? I don't like tabs either, but I like inconsistency even less.
You need to rebase onto develop to fix the docs build error.

src/modm/driver/radio/sx1276_impl.hpp Outdated Show resolved Hide resolved
src/modm/driver/radio/sx1276_impl.hpp Outdated Show resolved Hide resolved
src/modm/driver/radio/sx1276.hpp Outdated Show resolved Hide resolved
src/modm/driver/radio/sx1276_definitions.hpp Outdated Show resolved Hide resolved
src/modm/driver/radio/sx1276_impl.hpp Outdated Show resolved Hide resolved
@nesos nesos force-pushed the feature/sx1276-lora branch from 3db0a18 to b3da7a9 Compare June 13, 2020 12:56
@nesos
Copy link
Contributor Author

nesos commented Jun 13, 2020

A beautiful driver!

Thanks!
It's actually fun to write drivers for modm! I really like the cleanliness and type safe way of modm. :-)

@nesos
Copy link
Contributor Author

nesos commented Jun 13, 2020

You need to rebase onto develop to fix the docs build error.

I rebased the branch to develop and the error still shows up :-/

@salkinium
Copy link
Member

Did you fetch develop from this remote beforehand? You may have rebased on your fork's develop.

@nesos nesos force-pushed the feature/sx1276-lora branch from b3da7a9 to 3239fd3 Compare June 13, 2020 14:49
@salkinium
Copy link
Member

Do you want to squash your commits? One commit for the driver and one for the examples?

@nesos nesos force-pushed the feature/sx1276-lora branch from 3239fd3 to fd77d5f Compare June 13, 2020 16:16
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium salkinium force-pushed the feature/sx1276-lora branch from fd77d5f to 7d1f7cc Compare June 13, 2020 17:48
@salkinium
Copy link
Member

(One of your examples changes slipped into the first commit. I quickly fixed it instead of another round of review, hope that's ok.)

@salkinium salkinium merged commit 7d1f7cc into modm-io:develop Jun 13, 2020
@nesos nesos deleted the feature/sx1276-lora branch June 13, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants