Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spi] Enhance STM32 SPI with DMA support #400

Merged
merged 1 commit into from
May 8, 2020
Merged

[spi] Enhance STM32 SPI with DMA support #400

merged 1 commit into from
May 8, 2020

Conversation

mikewolfram
Copy link
Contributor

No description provided.

@mikewolfram mikewolfram force-pushed the stm32_spi_dma branch 4 times, most recently from 4cca1b5 to 8e8e8ed Compare May 7, 2020 13:44
rleh
rleh reviewed May 7, 2020
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

src/modm/platform/spi/stm32/module.lb Outdated Show resolved Hide resolved
src/modm/platform/spi/stm32/module.lb Outdated Show resolved Hide resolved
examples/nucleo_l432kc/spi_dma/main.cpp Show resolved Hide resolved
salkinium
salkinium requested changes May 7, 2020
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

src/modm/board/nucleo_l432kc/board.hpp Show resolved Hide resolved
examples/nucleo_l432kc/spi_dma/main.cpp Outdated Show resolved Hide resolved
examples/nucleo_l432kc/spi_dma/main.cpp Outdated Show resolved Hide resolved
src/modm/platform/spi/stm32/spi_master_dma_impl.hpp.in Show resolved Hide resolved
rleh
rleh approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@salkinium salkinium merged commit 80a9c66 into modm-io:develop May 8, 2020
@mikewolfram mikewolfram deleted the stm32_spi_dma branch May 8, 2020 16:08
@salkinium salkinium mentioned this pull request Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleh rleh rleh approved these changes

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
advanced 🤯 example 🔑 feature 🚧
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikewolfram @salkinium @rleh