-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bsp for nucleo f303re #376
Feature/bsp for nucleo f303re #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @luxarf, thanks for your first contribution to modm!
The pull request looks mostly fine to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the copyright is fine for files you only copied, but the module.lb
should have your name.
Apart from that, can you squash your commits onto just one?
(We really need to generate these examples from a common source, this is copy-paste is really getting out of control 🤪🙈) |
See #359 😉 |
After a little back and forth with git (I am doing a squash for the first time), I am hopeful I got everything. |
Hm sorry, I forgot: You also need to add your new examples to the CI in the - (cd examples && ../tools/scripts/examples_compile.py stm32f3_discovery nucleo_f303k8)
+ (cd examples && ../tools/scripts/examples_compile.py stm32f3_discovery nucleo_f303k8 nucleo_f303re) I need to write a test that checks that all examples are in the CI, I've also added examples and forgot to add them to the CI. Whoops. |
Although the ci checks pass, I am seeing deprecation warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, thanks!
I would like to use a Nucleo F303RE with modm and therefore added board support for this development board.
This pull request contains nothing major, the board support files are slightly modified copies of the very similar Nucloe F303K8, corrected for the different form factor.
The examples are slightly modified copies from the examples for the aforementioned Nucleo F303K8 and the Nucleo F103RB.
I verified that the examples are running on the Nucleo F303RE Board that is available to me.
What else needs to be done to make this Pull Request mergeable?