Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver for LP503x I2c PWM LED driver #366

Merged
merged 2 commits into from
May 12, 2020

Conversation

chris-durand
Copy link
Member

Driver for LP503x LED driver. Most functionality has been tested on a custom board with an STM32F042K6 some time ago. Unfortunately, I don't have access to the hardware right now and can't run the Nucleo F042K6 example on actual hardware.

Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

I'll try to test the driver as soon as I have access to the hardware!

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/modm/driver/pwm/lp503x_impl.hpp.in Show resolved Hide resolved
@salkinium
Copy link
Member

I'll wait for @rleh to test in hardware and when he approves again, I'll merge.

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium
Copy link
Member

Note to self: it may take a few weeks until access to hardware is possible again.

src/modm/driver/pwm/lp503x_impl.hpp.in Outdated Show resolved Hide resolved
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on hardware!

grafik

README.md Outdated Show resolved Hide resolved
@rleh
Copy link
Member

rleh commented May 12, 2020

Merge @salkinium?

@salkinium salkinium merged commit 6e5ebf4 into modm-io:develop May 12, 2020
@chris-durand chris-durand deleted the feature/lp503x branch January 2, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants