[c++] Add static initialization guards for Cortex-M #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hopefully atomic statics initialization guard implementation to implement #345.
In case of recursive initialization, a debug assertion
cxa.guard.recursion
is raised.For AVRs, the threadsafe statics are not implemented at all to save code space.
Should the guard implementation be optional for ARM Cortex-M? The guard itself takes 4 bytes per function static, and the guards a little bit of code. I don't think this is too much size, but for very small targets it may be useful to have this as an option. I'm also not aware of this not being atomic being an issue in the past.
Not sure how to overwrite this for FreeRTOS use, I'll fix it when it becomes an issue.
cc @chris-durand @rleh @dergraaf