Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dummy parameter to Timer::isChannelConfiguredAsInput for 1 channel #344

Conversation

dhebbeker
Copy link
Contributor

Added dummy parameter to Timer::isChannelConfiguredAsInput for timers which have only one channel.

This allows a unified interface for all general purpose timers, independent of the number of available channels. As a default argument is given, it is backwards compatible.

@salkinium
Copy link
Member

salkinium commented Mar 12, 2020

arm-none-eabi/bin/ld: /test/build/test/release/test.elf section `.data' will not fit in region `FLASH'
arm-none-eabi/bin/ld: region `FLASH' overflowed by 76 bytes
collect2: error: ld returned 1 exit status

@rleh I guess there's a small regression in the new GCC version that makes the flash overflow on the F103 unittests. I've fixed this in #343.

… with 1 channel only.

This allows a unified interface for all general purpose timers, independent of the number of available channels.
@dhebbeker dhebbeker force-pushed the feature/add-dummy-parameter-to-timer-isChannelConfiguredAsInput branch from 648a9e5 to 4978db8 Compare March 14, 2020 16:03
@salkinium salkinium requested a review from rleh March 14, 2020 16:18
@salkinium salkinium merged commit 4978db8 into modm-io:develop Mar 14, 2020
@dhebbeker
Copy link
Contributor Author

Thank you @rleh and @salkinium for your prompt reaction and review. 💐 It motivates me to contribute to this awesome project. 👍

@salkinium
Copy link
Member

Thanks for the feedback, that's what we aim for!

I'm curious to know what you're using modm for? If it's a professional project, how does modm integrate into your team's workflow? Do you have some feedback about how the code generation step is accepted by other team members? What parts of modm need improvement?

@dhebbeker
Copy link
Contributor Author

dhebbeker commented Mar 14, 2020 via email

@salkinium
Copy link
Member

For the moment I am only generating classes for hand-picked peripheral and
include those in legacy software.

Excellent, that was what I had in mind with our ulta-modularized HAL: Be able to only generate the absolute bare-minimum of code required and then integrate it into your own project.

Code generation is definitively smoother in Linux environments

Good Windows support is… interesting. So much stupid, so much pain.

At the moment the documentation and manual is very important for me.

Yes, it's much better than with xpcc, particularly now that @rleh got the API docs working so nicely!

I greatly appreciate the Getting Started manual!

Looking back at it now, I find it a bit chaotic, I need to rewrite it to be clearer in places. See also issue #280, which I haven't had the mental space to get into yet. Writing docs is very difficult without a proper review.

As I understand questions are to be asked as issues in Github.

Absolutely!

@dhebbeker dhebbeker deleted the feature/add-dummy-parameter-to-timer-isChannelConfiguredAsInput branch March 16, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants