Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SConstruct generation on Windows #329

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

dhebbeker
Copy link
Contributor

I got the following error message before:

(modm) C:\Users\hebbeker.ST\Documents\modm_tests\modm\examples\stm32f4_discovery\timer>scons
scons: Reading SConscript files ...
OSError: [WinError 123] Die Syntax für den Dateinamen, Verzeichnisnamen oder die Datenträgerbezeichnung ist falsch: 'C:\\Users\\hebbeker.ST\\Documents\\modm_tests\\modm\\examples\\..\x08uild':
  File "C:\Users\hebbeker.ST\Documents\modm_tests\modm\examples\stm32f4_discovery\timer\SConstruct", line 26:
    env.SConscript(dirs=generated_paths, exports="env")

Fixes #299.

I got the following error message *before*:

```
(modm) C:\Users\hebbeker.ST\Documents\modm_tests\modm\examples\stm32f4_discovery\timer>scons
scons: Reading SConscript files ...
OSError: [WinError 123] Die Syntax für den Dateinamen, Verzeichnisnamen oder die Datenträgerbezeichnung ist falsch: 'C:\\Users\\hebbeker.ST\\Documents\\modm_tests\\modm\\examples\\..\x08uild':
  File "C:\Users\hebbeker.ST\Documents\modm_tests\modm\examples\stm32f4_discovery\timer\SConstruct", line 26:
    env.SConscript(dirs=generated_paths, exports="env")
```
@dhebbeker dhebbeker marked this pull request as ready for review February 25, 2020 16:21
@dhebbeker dhebbeker requested a review from salkinium February 25, 2020 16:22
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium
Copy link
Member

However, also see related issues for Windows path seperators #310 (comment) and the underlying lbuild issue (modm-io/lbuild#51), which I currently have no time to properly solve.

@salkinium salkinium merged commit 5ab9d7b into modm-io:develop Feb 26, 2020
@dhebbeker dhebbeker deleted the patch-1 branch February 28, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Non-escaped backslashes in SConstruct file on Windows
2 participants