Add support for STM32G4 family

[rleh]

• Blink example compiles! 😉
• Adapt peripherals
  • ADC
  • DAC There is generally no DAC driver yet.
  • Comparator
  • New FDCAN driver -> different PR
• Add Nucleo-G474RE BSP and examples
• Test on real hardware

[rleh]

There are a lot of this redefined errors:

modm/src/modm/platform/uart/uart_base.hpp:25: warning: "USART_ISR_RXNE" redefined
   25 | #define USART_ISR_RXNE    USART_ISR_RXNE_RXFNE
      | 
In file included from modm/src/modm/platform/clock/../device.hpp:25,
[...]
modm/ext/cmsis/device/stm32g474xx.h:15998: note: this is the location of the previous definition
15998 | #define USART_ISR_RXNE               USART_ISR_RXNE_Msk                        /*!< Read Data Register Not Empty */

Another ST inconsistency?

[salkinium]

Please update the STM32 CMSIS Header submodule to the latest commit, so that you're not working with bugs that have already been fixed!

[salkinium]

ST already fixed their own header files:

#define USART_CR1_TXEIE_Pos          (7U)
#define USART_CR1_TXEIE_Msk          (0x1UL << USART_CR1_TXEIE_Pos)            /*!< 0x00000080 */
#define USART_CR1_TXEIE              USART_CR1_TXEIE_Msk                       /*!< TXE Interrupt Enable */
#define USART_CR1_TXEIE_TXFNFIE_Pos  USART_CR1_TXEIE_Pos
#define USART_CR1_TXEIE_TXFNFIE_Msk  USART_CR1_TXEIE_Msk                       /*!< 0x00000080 */
#define USART_CR1_TXEIE_TXFNFIE      USART_CR1_TXEIE_Msk                       /*!< TXE and TX FIFO Not Full Interrupt Enable */

and

#define USART_ISR_TXE_Pos            (7U)
#define USART_ISR_TXE_Msk            (0x1UL << USART_ISR_TXE_Pos)              /*!< 0x00000080 */
#define USART_ISR_TXE                USART_ISR_TXE_Msk                         /*!< Transmit Data Register Empty */
#define USART_ISR_TXE_TXFNF_Pos      USART_ISR_TXE_Pos
#define USART_ISR_TXE_TXFNF_Msk      USART_ISR_TXE_Msk                       /*!< 0x00000080 */
#define USART_ISR_TXE_TXFNF          USART_ISR_TXE_Msk                       /*!< Transmit Data Register Empty or TX FIFO Not Full Flag */

So the lines in uart_base.hpp requires a few #ifndef.

[salkinium]

See my branch here: https://github.com/salkinium/modm/tree/feature/stm32g4

[rleh]

The build-docs CI job fails:

...
Merging module tree...
/bin/bash: line 1:   405 Killed                  python3 tools/scripts/generate_module_docs.py
Exited with code 137

Hint: Exit code 137 typically means the process is killed because it was running out of memory
Hint: Check if you can optimize the memory usage in your app
Hint: Max memory usage of this container is 4283166720
 according to /sys/fs/cgroup/memory/memory.max_usage_in_bytes

[salkinium]

Try this patch, it should only use 1.5GB of memory by merging the module tree immediately instead of storing all trees and then merging (which was stupid).
https://gist.github.com/salkinium/4cd2509cb2bf8d28ac2c022320fa11f5

[rleh]

There is a issue with OpenOCD: The latest OpenOCD Version (0.10.0 from January 2017) neither supports the STM32G4 as a target, nor the ST-Link V3 on the Nucleo-G474RE board.

There is probably no way out to use a newer OpenOCD version than 0.10.0. So compile OpenOCD yourself or use the AUR version (Git HEAD) for Arch-Linux.

To fix the missing STM32G4 support I will try to add the necessary files in tools/openocd/modm/.

StLink-V3 support: http://openocd.zylin.com/#/c/4717/
STM32G4 support: http://openocd.zylin.com/#/c/4807/

[salkinium]

OpenOCD also has no STM32G0 support either, I've been using the ST-Link mass storage device to flash it, but debugging would be useful too. OpenOCD has a very slow PR process, as in like multiple years.

[salkinium]

Tested in hardware?

[rleh]

Test on real hardware: ✅

Merge?

[salkinium]

Can you add the family to the README, and check if there're any other docs that need updating?

[salkinium]

Is the linkerscript chosen correctly?

[rleh]

Is the linkerscript chosen correctly?

The ICCM Linkerscript is chosen, looks right to me.

[rleh]

Can you add the family to the README, and check if there're any other docs that need updating?

README done.
I cannot find any other documents that need to be updated.

[salkinium]

Fantastic!

[rleh]

I wrote a small blog-post about how to compile OpenOCD with support for STM32G0 and STM32G4:
https://rleh.de/2019/10/08/openocd-stm32-stm32g4-stm32g0.html