Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lbuild] Warn if submodules are not up-to-date #267

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

salkinium
Copy link
Member

Adds a more comprehensive check for distiguishing between missing submodules (error) and out-of-date submodules (warning).

cc @se-bi

@se-bi
Copy link
Contributor

se-bi commented Aug 7, 2019

Does it through an error, if it is out of sync?

Does it distinguish between old state and something to be tested, if that occurs often with the submodules?

@salkinium
Copy link
Member Author

Does it through an error, if it is out of sync?

No, since that would be quite annoying for me.

Does it distinguish between old state and something to be tested, if that occurs often with the submodules?

No, it only checks if the submodule hexsha is the current checkout hexsha.

@salkinium
Copy link
Member Author

salkinium commented Aug 7, 2019

I could probably add a way to fail when calling lbuild verbosely with lbuild -v discover, would that help? (this would be quite fragile, how often do you call lbuild -v?)

@se-bi
Copy link
Contributor

se-bi commented Aug 7, 2019

Mhm, sorry. I had a comment on a different Issue in mind.

Warning is fine, user must just find it. 😝

@se-bi
Copy link
Contributor

se-bi commented Aug 7, 2019

I could probably add a way to fail when calling lbuild verbosely with lbuild -v discover, would that help? (this would be quite fragile, how often do you call lbuild -v?)

The lbuild discover should not fail, but big red warning at the end would be an option 😉

@salkinium
Copy link
Member Author

The lbuild discover should not fail, but big red warning at the end would be an option 😉

Hm, I can only put it at the beginning for now (it's using barebone printf), since there isn't a lbuild API for checking the repo.lb validity. Maybe this is a good idea to add to the init function…

@salkinium salkinium merged commit 72d5ae9 into modm-io:develop Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants