Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Remove Python 2 #254

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Conversation

strongly-typed
Copy link
Collaborator

Default to Python 3. I updated the docker container to run all scons scripts in Python 3 as well.

@strongly-typed
Copy link
Collaborator Author

See also modm-ext/docker-modm-build#5

salkinium
salkinium previously approved these changes Jul 24, 2019
@salkinium
Copy link
Member

I'm not merging this until the GitHub CI is fixed.

@strongly-typed
Copy link
Collaborator Author

strongly-typed commented Jul 24, 2019

I'm not merging this until the GitHub CI is fixed.

All jobs seem to have succeeded on CircleCI.

What fix do you expect from 'GitHub CI'?

@salkinium
Copy link
Member

All jobs seem to have succeed on CircleCI.

No, all jobs succeeded on YOUR CircleCI instance which isn't correctly displayed here.

What fix do you expect from 'GitHub CI'?

I expect not to have to treat your contributions as special PRs. Now I have to go and manually check if all the jobs succeeded. I know this is a bug not related to you, yet this is just more busy work for me for no reason. Why do I even have to argue about this?

@strongly-typed
Copy link
Collaborator Author

I expect not to have to treat your contributions as special PRs. Now I have to go and manually check if all the jobs succeeded. I know this is a bug not related to you, yet this is just more busy work for me for no reason. Why do I even have to argue about this?

Keep calm ;-). Of course you don't have to argue that this is unnecessary extra work. I just learnt that the behaviour of my PR is different to other PRs. I was assuming that this was kind of (bad) design of Github/CircleCI to reuse the contributor's CI.

Do you have any clue how to change the behaviour? Can I do something about it?

@strongly-typed
Copy link
Collaborator Author

This might help:

https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

I'll work on it today.

@salkinium
Copy link
Member

I just learnt that the behaviour of my PR is different to other PRs. I was assuming that this was kind of (bad) design of Github/CircleCI to reuse the contributor's CI.

Well… on the upside: your PRs are ✨ truly ✨ special ✨ 🤪

@salkinium
Copy link
Member

Just FYI: the modm-build docker is finished, so any builds are now using the latest gcc toolchain.

@salkinium
Copy link
Member

Yay, the CI is working correctly again! 🍾 🎉 🎊

@strongly-typed
Copy link
Collaborator Author

image

Here you go, the job was now triggered on the organisation's CI 😎🥳

Need to check later if the branches of my fork are still being build without a PR.

@strongly-typed
Copy link
Collaborator Author

Just FYI: the modm-build docker is finished, so any builds are now using the latest gcc toolchain.

Great to hear! ... and without Python2. So you should merge this asap.

salkinium
salkinium previously approved these changes Jul 24, 2019
@salkinium
Copy link
Member

So you should merge this asap.

Then you should rebase asap. 😛

@salkinium salkinium merged commit 00471ca into modm-io:develop Jul 24, 2019
@strongly-typed strongly-typed deleted the feature/python3 branch July 24, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants