-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Remove Python 2 #254
[ci] Remove Python 2 #254
Conversation
See also modm-ext/docker-modm-build#5 |
I'm not merging this until the GitHub CI is fixed. |
All jobs seem to have succeeded on CircleCI. What fix do you expect from 'GitHub CI'? |
No, all jobs succeeded on YOUR CircleCI instance which isn't correctly displayed here.
I expect not to have to treat your contributions as special PRs. Now I have to go and manually check if all the jobs succeeded. I know this is a bug not related to you, yet this is just more busy work for me for no reason. Why do I even have to argue about this? |
Keep calm ;-). Of course you don't have to argue that this is unnecessary extra work. I just learnt that the behaviour of my PR is different to other PRs. I was assuming that this was kind of (bad) design of Github/CircleCI to reuse the contributor's CI. Do you have any clue how to change the behaviour? Can I do something about it? |
This might help: I'll work on it today. |
Well… on the upside: your PRs are ✨ truly ✨ special ✨ 🤪 |
a97070d
to
cf8c9ea
Compare
Just FYI: the modm-build docker is finished, so any builds are now using the latest gcc toolchain. |
Yay, the CI is working correctly again! 🍾 🎉 🎊 |
Great to hear! ... and without Python2. So you should merge this asap. |
Then you should rebase asap. 😛 |
cf8c9ea
to
00471ca
Compare
Default to Python 3. I updated the docker container to run all scons scripts in Python 3 as well.