Add RCC module to abstract clock enable and reset #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salkinium
commented
Feb 28, 2019
|
|
||
| # FIXME: Move to modm:platform:core! | ||
| env.outbasepath = "modm/src/modm/platform/core" | ||
| env.template("peripherals.hpp.in") |
There was a problem hiding this comment.
modm-devices need to become smarter, right now it's just dumping the raw XML out it's API, so a lot of things need to be computed in modm that should be provided by modm-devices. Here, to compute the true set of addressable peripherals requires quite a bit of computation, which I don't want to duplicate in :platform:core module.
salkinium
commented
Feb 28, 2019
| @@ -37,6 +38,8 @@ public: | |||
| static inline void | |||
| enable() | |||
| { | |||
| Rcc::enable<Peripheral::Rng>(); | |||
| Rcc::reset<Peripheral::Rng>(); | |||
There was a problem hiding this comment.
Yeah, remember how the RNG never worked? HAVE YOU TRIED TURNING IT OFF AND ON AGAIN???
salkinium
commented
Feb 28, 2019
| # filter out MPU and/or FPU if required | ||
| peripherals = filter(lambda p: p[0] not in core_features or core_features[p[0]], peripherals) | ||
| peripherals = sorted(peripherals, key=lambda p: p[0]) | ||
| # print("\n".join([s+" -> "+hex(a) for (s,k,a) in peripherals])) | ||
|
|
||
| # Find all RCC enable and reset definitions | ||
| match = re.findall(r"RCC_([A-Z0-9]+?)_([A-Z0-9]+?)_(EN|RST) ", content) |
There was a problem hiding this comment.
Evil or genius? Why not both?
salkinium
force-pushed
the
feature/rcc
branch
from
e8a0cbc to
4a82a94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
modm::platform::Rccclass withRcc::enable<Peripheral>()Rcc::disable<Peripheral>()Rcc::reset<Peripheral>()methods, which are implemented by parsing the CMSIS header files to extract the peripheral name, register name and bit masks. This information be moved to modm-devices in the future, but for now this "hack" significantly improves modm by moving the
A{H,P}B{1,2}decisions from all peripherals into a common module.cc @rleh @chris-durand