Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] Deprecate Protothreads/Resumables in favor of Fibers #1232

Merged
merged 7 commits into from
Dec 1, 2024

Conversation

salkinium
Copy link
Member

@salkinium salkinium commented Nov 23, 2024

Fibers are now feature complete, so we're gonna pull the trigger and deprecate Protothreads and Resumables.
The goal is to deprecate Protothreads for now in a backward compatible way (ie. not removing resumables just yet) so that people have time to transition their code. Then in the mean time, I'll de-resumble some common sensor drivers and see what possibilities arise from that. There are also a few more things to take care of, such as fiber-local logging etc.

  • Enable Protothread implemented by Fibers by default
  • Port ~50 examples using Protothreads to Fibers
  • Small fixes and cleanup in drivers
  • Testing
  • Docs

@salkinium salkinium added this to the 2024q4 milestone Nov 23, 2024
@salkinium salkinium force-pushed the feature/deprecate_resumables branch 9 times, most recently from 11468ee to bf5ccbc Compare November 28, 2024 23:09
@salkinium salkinium marked this pull request as ready for review November 28, 2024 23:52
@salkinium salkinium force-pushed the feature/deprecate_resumables branch 2 times, most recently from 7c04522 to cd5604e Compare November 29, 2024 22:00
@salkinium salkinium linked an issue Nov 30, 2024 that may be closed by this pull request
@salkinium salkinium force-pushed the feature/deprecate_resumables branch from cd5604e to 95851d8 Compare November 30, 2024 14:35
@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label Nov 30, 2024
@salkinium salkinium force-pushed the feature/deprecate_resumables branch from 95851d8 to f81acae Compare November 30, 2024 16:20
@salkinium salkinium force-pushed the feature/deprecate_resumables branch from f81acae to 324cff9 Compare November 30, 2024 16:42
@salkinium salkinium force-pushed the feature/deprecate_resumables branch 2 times, most recently from ab0e032 to 17e7d24 Compare November 30, 2024 19:32
@salkinium salkinium force-pushed the feature/deprecate_resumables branch from 17e7d24 to b663c85 Compare November 30, 2024 19:57
@salkinium salkinium added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Dec 1, 2024
@salkinium salkinium merged commit 9e480a8 into modm-io:develop Dec 1, 2024
40 checks passed
@salkinium salkinium deleted the feature/deprecate_resumables branch December 1, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Resumable functions don't compile with gcc13
1 participant