[stm32] add advanced initialize on iwdg #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleh
approved these changes
Mar 8, 2024
victorandrehc
force-pushed
the
feature/advanced_iwdg
branch
from
54e013d to
3bf6c81
Compare
salkinium
reviewed
Mar 8, 2024
| initialize(Prescaler prescaler, uint16_t reload) | ||
| { | ||
| configure(prescaler, reload); | ||
| } |
There was a problem hiding this comment.
Let's instead rename configure to initialize and move it here to avoid the unnecessary forwarding.
There was a problem hiding this comment.
Just pushed a version without the forwarding. Please also don't forget the PR #1136.
victorandrehc
force-pushed
the
feature/advanced_iwdg
branch
from
3bf6c81 to
97067a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reinstates the ability to directly set the prescale and reload values on iwdg without letting modm to calculate this value directly.