Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32H7 SPI + Exti fixes + BMI088 driver #1052

Merged
merged 8 commits into from
Oct 5, 2023
Merged

STM32H7 SPI + Exti fixes + BMI088 driver #1052

merged 8 commits into from
Oct 5, 2023

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Jul 20, 2023 •
edited
Loading

  • STM32H7 SPI with DMA
  • Add interface to DMA driver to read transfer status
  • BMI088 IMU
    • Driver
    • SPI example
    • I²C example
    • Add documentation
  • Fix spurious EXTI interrupts with multiple enabled lines sharing the same IRQ
  • Fix compilation of Exti::disconnect()
  • Move identical copy-pasted SpiMaster::acquire()/release() code out of drivers
  • Allow use of SPI with fibers without :processing:protothread module

@chris-durand chris-durand changed the title STM32H7 SPI + Exti fixes STM32H7 SPI + Exti fixes + BMI088 driver Jul 20, 2023
@chris-durand chris-durand marked this pull request as draft July 20, 2023 15:22
@chris-durand chris-durand force-pushed the feature/stm32h7_spi branch from 3e21179 to 2f54174 Compare July 20, 2023 15:31
@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Jul 20, 2023
@chris-durand chris-durand force-pushed the feature/stm32h7_spi branch from 2f54174 to e9cb981 Compare July 20, 2023 22:49
@chris-durand chris-durand removed the ci:hal Triggers the exhaustive HAL compile CI jobs label Jul 20, 2023
@chris-durand chris-durand force-pushed the feature/stm32h7_spi branch 5 times, most recently from a154241 to f25619d Compare July 20, 2023 23:57
salkinium
salkinium reviewed Aug 6, 2023
View reviewed changes
examples/nucleo_h723zg/bmi088/spi/main.cpp Show resolved Hide resolved
src/modm/architecture/interface/spi_lock.hpp Show resolved Hide resolved
src/modm/driver/inertial/bmi088_impl.hpp Show resolved Hide resolved
src/modm/driver/inertial/bmi088_impl.hpp Show resolved Hide resolved
src/modm/driver/inertial/bmi088_transport.hpp Show resolved Hide resolved
src/modm/driver/inertial/bmi088_transport_impl.hpp Show resolved Hide resolved
src/modm/platform/extint/stm32/exti.cpp.in Outdated Show resolved Hide resolved
src/modm/platform/spi/sam/module.lb Outdated Show resolved Hide resolved
src/modm/platform/spi/stm32h7/spi_base.hpp.in Show resolved Hide resolved
src/modm/platform/spi/stm32h7/spi_base.hpp.in Show resolved Hide resolved
@rasmuskleist rasmuskleist mentioned this pull request Aug 7, 2023
Merged
@twast92 twast92 mentioned this pull request Sep 2, 2023
Merged
@chris-durand chris-durand marked this pull request as ready for review October 4, 2023 22:35
@chris-durand chris-durand requested a review from salkinium October 4, 2023 22:36
@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Oct 4, 2023
salkinium
salkinium approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very nice! Thanks!

@salkinium salkinium merged commit a771042 into modm-io:develop Oct 5, 2023
40 checks passed
@salkinium salkinium added this to the 2023q4 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs example 🔑 feature 🚧 refactor 🔥
Milestone
2023q4
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-durand @salkinium