Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add STM32H7 ADC driver + ADC injected conversions #1049

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Add STM32H7 ADC driver + ADC injected conversions #1049

merged 4 commits into from
Jul 27, 2023

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Jul 12, 2023 •
edited
Loading

  • STM32H7 16-bit ADC support
  • STM32H7 12-bit ADC support
  • ADC injected conversions
  • Examples for Nucleo H723ZG
    • Simple ADC
    • ADC injected conversions

@chris-durand chris-durand force-pushed the feature/stm32h7_adc branch 2 times, most recently from 4420a21 to fd44c36 Compare July 12, 2023 12:34
@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Jul 12, 2023
@rleh rleh removed the ci:hal Triggers the exhaustive HAL compile CI jobs label Jul 12, 2023
@rleh rleh self-requested a review July 12, 2023 21:26
salkinium
salkinium reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks!

src/modm/platform/adc/stm32f3/adc.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/adc/stm32f3/adc_impl.hpp.in Show resolved Hide resolved
src/modm/platform/adc/stm32f3/adc_impl.hpp.in Outdated Show resolved Hide resolved
@chris-durand chris-durand force-pushed the feature/stm32h7_adc branch from fd44c36 to 8bc474f Compare July 17, 2023 10:13
salkinium
salkinium approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very nice!

@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label Jul 17, 2023
@chris-durand chris-durand force-pushed the feature/stm32h7_adc branch from 8bc474f to 4d69227 Compare July 27, 2023 09:21
@chris-durand chris-durand added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Jul 27, 2023
@chris-durand chris-durand merged commit 4d69227 into modm-io:develop Jul 27, 2023
@chris-durand chris-durand deleted the feature/stm32h7_adc branch July 27, 2023 15:21
@salkinium salkinium added this to the 2023q3 milestone Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

@rleh rleh Awaiting requested review from rleh

Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs example 🔑 feature 🚧
Milestone
2023q3
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-durand @salkinium @rleh