Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[board] Add Adafruit Feather M4 Express BSP and examples #1032

Merged
merged 5 commits into from Jun 8, 2023
Merged

[board] Add Adafruit Feather M4 Express BSP and examples #1032

merged 5 commits into from Jun 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2023

Adafruit Feather M4 Express BSP and examples

@salkinium salkinium added this to the 2023q2 milestone Jun 2, 2023
@salkinium salkinium self-requested a review June 2, 2023 19:52
@salkinium salkinium changed the title Feature/board feather m4 [board] Add Adafruit Feather M4 Express BSP and examples Jun 2, 2023
@chris-durand chris-durand self-requested a review June 3, 2023 19:45
chris-durand
chris-durand reviewed Jun 3, 2023
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The board needs to be added here that the examples are compiled in the CI run.

Also, please run python3 tools/scripts/synchronize_docs.py in the modm top level folder and commit the updated README.md file.

examples/feather_m4/blink/main.cpp Outdated Show resolved Hide resolved
src/modm/board/feather_m4/board.hpp Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jun 4, 2023

I ran "synchronize_docs.py", committed and pushed README.md. Then I spotted a typo in that file, and changed "you specific needs" to "your specific needs", committed and pushed it. Big mistake, I guess. Now it appears it's failing the test at that point. I tried to undo it from my local repo but have run into a "divergent branch" situation that I'm unsure how to fix. I don't believe there's really anything wrong with the file.

salkinium
salkinium approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, thanks!

@salkinium salkinium requested a review from chris-durand June 7, 2023 20:53
chris-durand
chris-durand approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost
Copy link
Author

ghost commented Jun 7, 2023

Thanks to your both for your patience! I now understand the process somewhat better, although I am still not friends with git just yet :-)
This is a great project, hope to do more in the future!

@salkinium
Copy link
Member

I've squashed and rebased your commits and will merge after the CI passes. Thanks!

@salkinium salkinium merged commit 81b86be into modm-io:develop Jun 8, 2023
@ghost ghost deleted the feature/board_feather_m4 branch June 8, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
example 🔑 feature 🚧
Milestone
2023q2
Development

Successfully merging this pull request may close these issues.
2 participants
@salkinium @chris-durand