-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [stm32] F469 disco hardware rev b08 display driver nt35510 #1003
base: develop
Are you sure you want to change the base?
Conversation
Display is not starting yet 😢 Also, It seems that the touch driver is slightly different version in B-08: |
305381b
to
54c7883
Compare
@@ -14,7 +14,7 @@ | |||
def init(module): | |||
module.name = ":board:disco-f469ni" | |||
module.description = FileReader("module.md") | |||
# Revisions = [b-03, b-02, b-01] | |||
# Revisions = [c-01, b-08, b-03, b-02, b-01] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remenber correctly the first revision in the list is the "default" revision. Not sure if we should change the default revision to C-01
(yet)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not (yet)?
Also - do you happen to have one of the b-08
or c-01
revision boards, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you happen to have one of the
b-08
orc-01
revision boards, too?
Not yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok :-D I just ordered a second one - just to make sure, that my first display isn't defective :-D
case NT35510_FORMAT_RGB888 : | ||
/* Set Pixel color format to RGB888 */ | ||
dsi_write_command(1, nt35510_reg37); | ||
break; | ||
default : | ||
/* Set Pixel color format to RGB888 */ | ||
dsi_write_command(1, nt35510_reg37); | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case NT35510_FORMAT_RGB888 : | |
/* Set Pixel color format to RGB888 */ | |
dsi_write_command(1, nt35510_reg37); | |
break; | |
default : | |
/* Set Pixel color format to RGB888 */ | |
dsi_write_command(1, nt35510_reg37); | |
break; | |
case NT35510_FORMAT_RGB888 : | |
default : | |
/* Set Pixel color format to RGB888 */ | |
dsi_write_command(1, nt35510_reg37); | |
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I basically generated the code using CubeMX and then reformatted it. That's why there's a new copyright header in the middle of it. I never read the datasheet or understood any of it tbh. I also have a feeling that there is some pixel data offset mistake in the original driver, I think there are two pixels in the top left and one pixel in the bottom right that have the wrong color, but I never could fix it. Maybe it was just my display who knows, MIPI-DSI is basically magic.
54c7883
to
085e43f
Compare
Well thats exactly what I am trying at the moment - and failing. I'm still not even sure my discovery board works (I have not managed to compile and flash an ST example that would bring up the display...) |
085e43f
to
31e1ab3
Compare
@rleh For documentation; managed to generate ST example with TouchGFXDesigner (the experience was quite traumatizing) which brings up the display marked Went through the ST code - the reformatted Debugger says |
// Select the color coding for the wrapper | ||
DSI->WCFGR = ColorCoding << 1; | ||
// DSI_VSYNC_RISING | ||
DSI->WCFGR = DSI_WCFGR_VSPOL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit odd. In Line 77, WCFGR
is set to 0, then to ColorCoding <<1
and then to DSI_WCFGR_VSPOL
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second assignment should probably be DSI->WCFGR |= DSI_WCFGR_VSPOL;
.
Thanks for catching this and notifying here!
First attempt to fix #1002 by using the ST driver for nt35510.
This is for the STM32F469 example in
examples/stm32f469_discovery/display