Fixed static_assert

modm-io · Mar 17, 2021 · 3017e9a · 3017e9a
1 parent 9e63605
commit 3017e9a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/modm/driver/encoder/encoder.hpp b/src/modm/driver/encoder/encoder.hpp
@@ -37,15 +37,18 @@ template<typename PH_A, typename PH_B, encoder::Division_t DIVISION,
 		 typename UnderlyingType = int8_t>
 class Encoder
 {
+	static_assert(std::is_signed<UnderlyingType>::value and std::is_integral<UnderlyingType>::value,
+				  "UnderlyingType must be signed integral");
+
 public:
-	Encoder() : enc_delta(0), raw_last(0) {};
+	Encoder() : enc_delta(0), raw_last(0){};
 
 	inline void
 	connect()
 	{
 		PH_A::setInput(::Gpio::InputType::PullUp);
 		PH_B::setInput(::Gpio::InputType::PullUp);
-		
+
 		// Tare power-on state
 		modm::delay(10us);
 		UnderlyingType raw = 0;

diff --git a/src/modm/driver/encoder/encoder_impl.hpp b/src/modm/driver/encoder/encoder_impl.hpp
@@ -6,8 +6,6 @@ template<typename PH_A, typename PH_B, modm::encoder::Division_t DIVISION, typen
 inline void
 modm::Encoder<PH_A, PH_B, DIVISION, UnderlyingType>::update()
 {
-	static_assert(std::is_signed<UnderlyingType>::value and std::is_integral<UnderlyingType>::value,
-				  "UnderlyingType must be signed integral");
 	// Tare on power-on
 	UnderlyingType raw = 0;
 	UnderlyingType diff;
@@ -27,8 +25,6 @@ template<typename PH_A, typename PH_B, modm::encoder::Division_t DIVISION, typen
 UnderlyingType
 modm::Encoder<PH_A, PH_B, DIVISION, UnderlyingType>::getValue()
 {
-	static_assert(std::is_signed<UnderlyingType>::value and std::is_integral<UnderlyingType>::value,
-				  "UnderlyingType must be signed integral");
 	cli();
 	UnderlyingType val = enc_delta;  // counts since last call
 	switch (DIVISION)