[cmath] Only use ISO math functions in avr-libm #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avr-libm does not provide float or long overloads of math functions, so linking against
__builtin_sinf
resolving to just::sinf
will fail.I discovered this when compiling the modm math unittests for avr, which uses
float
types and therefore callsstd::sin(float)
, which the stdlibc++ overloads to use__builtin_sinf
instead of just forwarding everything to__builtin_sin
.avr-libm is not very consistent about what overloads it provides though, and I'm not sure if this is the right fix, but it makes the unittests link and pass.
cc @chris-durand