Fix ci 2021 #147
Merged
Fix ci 2021 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pypy3 on travis now installs PyPy 7.3.1 (python 3.6) by default. Let's just drop support for older django on pypy3 for now, and if any demand arises we can always install it manually (on older Ubuntu we can at least). Refs: * https://docs.travis-ci.com/user/languages/python/ * https://travis-ci.org/github/modlinltd/django-advanced-filters/jobs/771133248
Sadly installing django-braces 1.14 causes an issue since it introduces an explicit Django version dependency: https://github.com/brack3t/django-braces/blob/v1.14.0/setup.py#L33 This in turn does not allow us to run on older django versions
* Use tox parallel (auto to use max cores) * Send coveralls github action * Use pytest-cov with cleanup and report task * remove .travis.yml Ref: * https://pytest-cov.readthedocs.io/en/latest/tox.html * https://pytest-cov.readthedocs.io/en/latest/config.html * https://tox.readthedocs.io/en/latest/example/devenv.html * https://github.com/marketplace/actions/coveralls-github-action
Seems to fail due to missing lcov, not sure how to make it work as a wrapper script yet
alonraiz
added a commit
to alonraiz/django-advanced-filters
that referenced
this pull request
Jul 11, 2021
* fix: move from ugettext to gettext ugettext() is an alias of gettext() since Django 2.0 In Django > 3.0 it generates RemovedInDjango40Warning * feat: add Latvian translation * Fix ci 2021 (modlinltd#147) * Limit pypy django versions and add 3.9 support pypy3 on travis now installs PyPy 7.3.1 (python 3.6) by default. Let's just drop support for older django on pypy3 for now, and if any demand arises we can always install it manually (on older Ubuntu we can at least). Refs: * https://docs.travis-ci.com/user/languages/python/ * https://travis-ci.org/github/modlinltd/django-advanced-filters/jobs/771133248 * Use github workflow Starts by cloning what we do on travis-ci. Refs: * https://github.com/ymyzk/tox-gh-actions * https://github.com/actions/setup-python#available-versions-of-pypy * https://downloads.python.org/pypy/versions.json * Remove .travis.yml * Remove dependency on django-braces Sadly installing django-braces 1.14 causes an issue since it introduces an explicit Django version dependency: https://github.com/brack3t/django-braces/blob/v1.14.0/setup.py#L33 This in turn does not allow us to run on older django versions * Use tox parallel (auto to use max cores) * Use pytest-cov with cleanup and report task Ref: * https://pytest-cov.readthedocs.io/en/latest/tox.html * https://pytest-cov.readthedocs.io/en/latest/config.html * https://tox.readthedocs.io/en/latest/example/devenv.html * https://github.com/marketplace/actions/coveralls-github-action * Remove coveralls upload Seems to fail due to missing lcov, not sure how to make it work as a wrapper script yet * Don't test twice, on PR is enough * Igor says this fixes a bug for him, but he's not sure it's the correct solution. Co-authored-by: Māris Nartišs <[email protected]> Co-authored-by: Pavel Savchenko <[email protected]> Co-authored-by: Zeev Tarantov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.