Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#392: Raise a warning if shared object storage is enabled but the MPI library does not support it #393

Merged
merged 2 commits into from
Nov 13, 2023
Merged

FEAT-#392: Raise a warning if shared object storage is enabled but the MPI library does not support it #393

merged 2 commits into from
Nov 13, 2023

Conversation

Retribution98
Copy link
Collaborator

@Retribution98 Retribution98 commented Nov 13, 2023 •
edited by YarShev
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 .
  • passes black .
  • signed commit with git commit -s
  • Resolves Raise a warning if shared object storage is enabled but the MPI library does not support it. #392
  • tests added and passing
  • module layout described at docs/developer/architecture.rst is up-to-date

@Retribution98
FEAT-modin-project#392: Send a warning if shared object storage is en…
2be323c 
…abled but the MPI library does not support it.

Signed-off-by: Kirill Suvorov <[email protected]>
@YarShev YarShev changed the title FEAT-#392: Send a warning if shared object storage is enabled but the… FEAT-#392: Raise a warning if shared object storage is enabled but the MPI library does not support it Nov 13, 2023
@YarShev
Some fixes
a150698 
Signed-off-by: Igoshev, Iaroslav <[email protected]>
@YarShev YarShev merged commit d96bb83 into modin-project:master Nov 13, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise a warning if shared object storage is enabled but the MPI library does not support it.
2 participants
@Retribution98 @YarShev