Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#376: Partition buffers of size larger than the _bigmpi.blocksize into blocks while sending and receiving with MPI #383

Merged
merged 4 commits into from
Nov 9, 2023
Merged

FIX-#376: Partition buffers of size larger than the _bigmpi.blocksize into blocks while sending and receiving with MPI #383

merged 4 commits into from
Nov 9, 2023

Conversation

arunjose696
Copy link
Contributor

@arunjose696 arunjose696 commented Nov 8, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 .
  • passes black .
  • signed commit with git commit -s
  • Resolves Unidist MPI backend fails on cluster for HM benchmark with OverflowError #376
  • tests added and passing
  • module layout described at docs/developer/architecture.rst is up-to-date

arunjose696 and others added 2 commits November 9, 2023 17:42
@arunjose696 @YarShev
Apply suggestions from code review
12f82ce 
Co-authored-by: Iaroslav Igoshev <[email protected]>
@arunjose696
black changes
5dca897 
Signed-off-by: arunjose696 <[email protected]>
@YarShev YarShev merged commit 694d196 into modin-project:master Nov 9, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unidist MPI backend fails on cluster for HM benchmark with OverflowError
2 participants
@arunjose696 @YarShev