Skip to content

Fix indexing 1-D series#27

Merged
devin-petersohn merged 4 commits intomodin-project:masterfrom
simon-mo:fix-indexing
Jul 7, 2018
Merged

Fix indexing 1-D series#27
devin-petersohn merged 4 commits intomodin-project:masterfrom
simon-mo:fix-indexing

Conversation

@simon-mo
Copy link
Collaborator

@simon-mo simon-mo commented Jul 6, 2018

What do these changes do?

There was a complication from PR #19 that breaks accessing a row using loc/iloc

Related issue number

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@devin-petersohn
Copy link
Collaborator

Would it be better to just revert #19 instead of adding all this extra logic?

@simon-mo
Copy link
Collaborator Author

simon-mo commented Jul 6, 2018

close in favor of reverting #19

@simon-mo simon-mo closed this Jul 6, 2018
@simon-mo simon-mo reopened this Jul 7, 2018
@simon-mo
Copy link
Collaborator Author

simon-mo commented Jul 7, 2018

I’m afraid this issue is general. That’s why it’s re-opened.

@devin-petersohn devin-petersohn merged commit 61d6cf4 into modin-project:master Jul 7, 2018
dchigarev pushed a commit to dchigarev/modin that referenced this pull request Aug 25, 2020
@xiwen1995 xiwen1995 mentioned this pull request Feb 4, 2021
6 tasks
mvashishtha pushed a commit to mvashishtha/modin that referenced this pull request Mar 31, 2023
vnlitvinov pushed a commit to vnlitvinov/modin that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants