Adding reproducible benchmarks#26
Merged
devin-petersohn merged 37 commits intomodin-project:masterfrom Jul 9, 2018
Merged
Conversation
kunalgosar
force-pushed
the
benchmarks
branch
3 times, most recently
from
d6c2335 to
8db8b44
Compare
* Adding join and merge benchmark * Updating run file * Addressing comments * ray.wait
* Add some plotting * Fix flake8
kunalgosar
changed the title
kunalgosar
added
the
Benchmarking 🏁
Collaborator
devin-petersohn
left a comment
devin-petersohn
left a comment
There was a problem hiding this comment.
Let a couple of comments. Overall looks good!
benchmarks/plots/log_parser.ipynb
Outdated
| @@ -0,0 +1,268 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
Is this needed in the repo?
Collaborator
Author
There was a problem hiding this comment.
I can remove it, if that is better.
modin/pandas/indexing.py
Outdated
|
|
||
| from .utils import (_get_nan_block_id, extractor, | ||
| _mask_block_partitions, writer, _blocks_to_series) | ||
| from .utils import (_get_nan_block_id, extractor, _mask_block_partitions, |
Collaborator
There was a problem hiding this comment.
I think this change and the change in utils should go in a separate PR.
@simon-mo You made these changes would you create that PR?
Collaborator
Author
There was a problem hiding this comment.
I've reverted these changes
devin-petersohn
approved these changes
Jul 9, 2018
Collaborator
devin-petersohn
left a comment
devin-petersohn
left a comment
There was a problem hiding this comment.
Looks great, thanks!
simon-mo
pushed a commit
that referenced
this pull request
Sep 25, 2018
* Reformatting code with black instead of yapf * Fix python2 issue * Add .flake8 file (#26) * remove unneeded diff
dchigarev
pushed a commit
to dchigarev/modin
that referenced
this pull request
Aug 25, 2020
Support for dt_year operation
mvashishtha
pushed a commit
to mvashishtha/modin
that referenced
this pull request
Mar 31, 2023
vnlitvinov
pushed a commit
to vnlitvinov/modin
that referenced
this pull request
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in reproducible benchmarking scripts.