-
Notifications
You must be signed in to change notification settings - Fork 675
Adding contribution templates #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <!-- | ||
| General questions should be asked on the mailing list modin-dev@googlegroups.com. | ||
|
|
||
| Before submitting an issue, please fill out the following form. | ||
| --> | ||
|
|
||
| ### System information | ||
| - **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: | ||
| - **Modin installed from (source or binary)**: | ||
| - **Modin version**: | ||
| - **Python version**: | ||
| - **Exact command to reproduce**: | ||
|
|
||
| <!-- | ||
| You can obtain the Modin version with | ||
|
|
||
| python -c "import modin; print(modin.__version__)" | ||
| --> | ||
|
|
||
| ### Describe the problem | ||
| <!-- Describe the problem clearly here. --> | ||
|
|
||
| ### Source code / logs | ||
| <!-- Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem. --> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <!-- | ||
| Thank you for your contribution! | ||
| --> | ||
|
|
||
| ## What do these changes do? | ||
|
|
||
| <!-- Please give a short brief about these changes. --> | ||
|
|
||
| ## Related issue number | ||
|
|
||
| <!-- Are there any issues opened that will be resolved by merging this change? --> | ||
|
|
||
| - [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work yet. We will need to make sure that we add this right before the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as of #24