Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize OrderedHashSet #448

Closed
kamronbatman opened this issue Feb 4, 2021 · 0 comments · Fixed by #679
Closed

Optimize OrderedHashSet #448

kamronbatman opened this issue Feb 4, 2021 · 0 comments · Fixed by #679

Comments

@kamronbatman
Copy link
Contributor

kamronbatman commented Feb 4, 2021 •
edited
Loading

Optimized the OrderedHashSet. See this:

Looks like the OrderedDictionary that I based this structure from was not updated.
See the source for diffing:
https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/HashSet.cs

Difference between a HashSet and an OrderedHashSet is updating the indexes of the entries after fixing the chain to preserve insertion order.
@kamronbatman kamronbatman changed the title Optimized OrderedHashSet Optimize OrderedHashSet Feb 4, 2021
@kamronbatman kamronbatman mentioned this issue Aug 8, 2021
Merged
kamronbatman added a commit that referenced this issue Aug 9, 2021
@kamronbatman
fix: Optimize OrderedHashSet and introduce more high perf collections (…
b0f8fe0 
…#679)

* Optimizes OrderedHashSet using the learnings here: dotnet/runtime#10050
* Removes ValueCollection since it was a relic from the conversion of the OrderedDictionary
* Centralizes throw strings.
* Adds pooled ordered hash set (but doesn't use it)

Closes #448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Optimize OrderedHashSet and introduce more high perf collections modernuo/ModernUO
1 participant
@kamronbatman