fix: upgrade OpenTUI for renderer stability - #538
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Greptile SummaryThis PR upgrades
Confidence Score: 5/5Safe to merge — the change is a focused patch-version bump of two packages with no API surface changes, and all lock files are fully synchronized. The dependency upgrade is narrow in scope (0.4.2 → 0.4.3 patch), both Bun and Nix locks are consistent with the new versions and hashes, peerDependencies are updated in lockstep with devDependencies, and the new PTY test directly exercises the previously-crashing overscroll path. No logic changes outside the test file. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Launch Hunk PTY] --> B[Wait for UI ready]
B --> C[scrollDown 30 to EOF]
C --> D{line18 = 118 visible?}
D -- yes --> E[Assert line01 not visible]
E --> F[scrollDown 12 overscroll]
F --> G{line18 = 118 still visible?}
G -- yes --> H[Renderer stable - no crash]
H --> I[scrollUp 30]
I --> J{line01 = 101 visible?}
J -- yes --> K[Test passes]
D -- timeout --> L[Test fails]
G -- timeout --> L
J -- timeout --> L
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Launch Hunk PTY] --> B[Wait for UI ready]
B --> C[scrollDown 30 to EOF]
C --> D{line18 = 118 visible?}
D -- yes --> E[Assert line01 not visible]
E --> F[scrollDown 12 overscroll]
F --> G{line18 = 118 still visible?}
G -- yes --> H[Renderer stable - no crash]
H --> I[scrollUp 30]
I --> J{line01 = 101 visible?}
J -- yes --> K[Test passes]
D -- timeout --> L[Test fails]
G -- timeout --> L
J -- timeout --> L
Reviews (1): Last reviewed commit: "fix: upgrade OpenTUI for renderer stabil..." | Re-trigger Greptile |
Summary
@opentui/coreand@opentui/reactto 0.4.3, picking up native-backed text measurement from OpenTUI #1219 to suppress Yoga NaN dimension warnings on Apple Silicon npm installsCloses #517.
Closes #525.
Testing
bun run typecheckbun run lintbun run testbun run test:integrationbun run test:tty-smokebun run build:npmbun run check:packThis PR description was generated by Pi using OpenAI GPT-5.6 Sol