Skip to content

[model] support GLM-5 (transformers) #8066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jintao-Huang merged 3 commits into from
Feb 24, 2026
Merged

[model] support GLM-5 (transformers) #8066

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0731303
compat megatron-core main branch
Jintao-Huang Feb 18, 2026
f4c209d
Merge branch 'main' into compat_megatron_core_main_123
Jintao-Huang Feb 24, 2026
1d8e27d
update glm5
Jintao-Huang Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions swift/megatron/trainers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import torch.nn
from megatron.core import mpu
from megatron.core.distributed import finalize_model_grads
from megatron.core.optimizer import OptimizerConfig, _update_min_and_max_lr_in_param_groups, get_megatron_optimizer
from megatron.core.optimizer import OptimizerConfig, get_megatron_optimizer
from megatron.core.pipeline_parallel import get_forward_backward_func
from megatron.core.transformer.module import MegatronModule
from megatron.core.transformer.moe.moe_utils import track_moe_metrics
Expand Down Expand Up @@ -243,7 +243,7 @@ def _get_param_groups(
Returns:
List of parameter groups.
"""
args = self.args
from megatron.core.optimizer import _update_min_and_max_lr_in_param_groups
Comment thread
Jintao-Huang marked this conversation as resolved.
Resolved
is_multimodal = args.megatron_model_meta.is_multimodal
if args.vit_lr is not None or args.aligner_lr is not None:
assert is_multimodal, 'vit_lr and aligner_lr are only supported for multimodal models.'
Expand Down
Loading