support emu3-chat #2322
Merged
support emu3-chat #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mi804
commented
Oct 23, 2024
mi804
commented
- Document Updates
- More Models or Datasets Support
| @@ -317,6 +317,8 @@ def __post_init__(self): | |||
| connector='aligner', | |||
| generator=['gen_vision_model', 'gen_aligner', 'gen_head', 'gen_embed']) | |||
|
|
|||
| EMU3_CHAT_KEYS = MultiModelKeys(language_model='model', ) | |||
swift/llm/utils/template.py
Outdated
| image_placeholder = ['<|image token|>'] | ||
|
|
||
| def __init__(self): | ||
| Template.__init__(self, [], [' User: {{QUERY}}. Assistant:'], ['<|extra_204|>'], ['<|extra_204|>'], self.system, |
There was a problem hiding this comment.
please check the user's previous ' '
swift/llm/utils/template.py
Outdated
| inputs, _ = super()._encode(example) | ||
| if len(inputs) == 0: | ||
| return inputs, {} | ||
| inputs['input_ids'] = [self.tokenizer.bos_token_id] + inputs['input_ids'] |
There was a problem hiding this comment.
please add bos_token in Template.__init__(self, [],..)
| self.tokenizer.boi_token + self.tokenizer.processor.prefix_template.format(H=h, W=w) | ||
| + self.tokenizer.img_token + imgstr + self.tokenizer.eol_token + self.tokenizer.eof_token | ||
| + self.tokenizer.eoi_token) | ||
| image_prompts.append(self.tokenizer.encode(image_prompt)) |
There was a problem hiding this comment.
please check add_special_tokens=False in encode function
There was a problem hiding this comment.
have checked, it's the same with offical implementation of emu3
| + 1:] | ||
| added_tokens_len += len(img_tokens) - 1 | ||
|
|
||
| return {'input_ids': input_ids, 'labels': labels} |
There was a problem hiding this comment.
please move post_encode code to encode
Jintao-Huang
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.