-
Notifications
You must be signed in to change notification settings - Fork 174
Version compatibility #4698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Version compatibility #4698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. I added some minor language suggestions.
Co-authored-by: Malte Lenz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should have consensus before merging, but it seems fine to me.
| <li>Any new parameter must have a default value.</li> | ||
| <li>Any new function input must be after existing inputs and have a default value.</li> | ||
| <li>Any new function output must be after existing outputs.</li> | ||
| </ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like is missing: Any new enumeration alternative must be after existing alternatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, and that made me realize that the same was true for records, and that both of them also imposed requirements on user models.
Co-authored-by: Thomas Beutlich <[email protected]>
Based on #4694 (the feedback from the MAP-Lib meeting was to make it a PR).
Basically:
I added a import-restriction for usage compared to issue, I hope I didn't miss anything else.