Skip to content

Conversation

HansOlsson
Copy link
Contributor

Based on #4694 (the feedback from the MAP-Lib meeting was to make it a PR).

Basically:

  • Clarifying bug-fixes releases a bit
  • Adding minor
  • Adding major (and the guarantee that we provide conversion scripts)
  • Most importantly giving a user perspective of how to safely use MSL

I added a import-restriction for usage compared to issue, I hope I didn't miss anything else.

@HansOlsson HansOlsson added the documentation Issue addresses the documentation label Oct 14, 2025
Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I added some minor language suggestions.

Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should have consensus before merging, but it seems fine to me.

@HansOlsson HansOlsson requested a review from casella October 14, 2025 13:48
<li>Any new parameter must have a default value.</li>
<li>Any new function input must be after existing inputs and have a default value.</li>
<li>Any new function output must be after existing outputs.</li>
</ul>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like is missing: Any new enumeration alternative must be after existing alternatives.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, and that made me realize that the same was true for records, and that both of them also imposed requirements on user models.

@beutlich beutlich added the L: UsersGuide Issue addresses Modelica.UsersGuide label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issue addresses the documentation L: UsersGuide Issue addresses Modelica.UsersGuide

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants