Skip to content

Conversation

@maltelenz
Copy link
Contributor

These originate from figures created for Wolfram System Modeler, and are likely to need cleanup and improvement.

Our one existing figure in MSL is probably a good style to follow:

figures = {
Figure(
title = "Anti-windup compensation",
identifier = "anti-windup",
preferred = true,
plots = {
Plot(
title = "Reference tracking",
identifier = "tracking",
curves = {
Curve(y = integrator.y, legend = "Reference speed"),
Curve(y = inertia1.w, legend = "Actual speed")}),
Plot(
title = "Anti-windup limiter",
identifier = "limiter",
curves = {
Curve(y = PI.limiter.u, legend = "Input to the anti-windup limiter"),
Curve(y = PI.y, legend = "Controller output")})},
caption = "%(plot:tracking) Reference speed (%(variable:integrator.y)) and the actual speed (%(variable:inertia1.w)). The system initializes in steady state, since no transients are present. The inertia follows the reference speed quite good until the end of the constant speed phase. Then there is a deviation.
%(plot:limiter) Here the reason for the deviation can be seen: The output of the controller (%(variable:PI.y)) is in its limits. The anti-windup compensation works reasonably, since the input to the limiter (%(variable:PI.limiter.u)) is forced back to its limit after a transient phase.
")}));

Creating as Draft to indicate that library officer(s) probably want/should improve them before merging.

These originate from figures created for Wolfram System Modeler, and are likely to need cleanup and improvement.
@maltelenz maltelenz added the figures Related to figures/plots label Jul 16, 2025
@beutlich beutlich added example Issue only addresses example(s) L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer labels Jul 25, 2025
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding starting point for figures - thx @maltelenz - fine with me!

@christiankral
Copy link
Contributor

I will delay the review of this PR until we resolve the discussion in #4674, #4675 and #4676.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

example Issue only addresses example(s) figures Related to figures/plots L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants