Update version, uses annotation and copyright year #4247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casella
requested review from
AHaumer,
GallLeo,
HansOlsson and
arunkumar-narasimhan
maltelenz
requested changes
Jan 10, 2024
Contributor
maltelenz
left a comment
maltelenz
left a comment
There was a problem hiding this comment.
Requesting changes according to comments.
beutlich
requested changes
Jan 10, 2024
Member
beutlich
left a comment
beutlich
left a comment
There was a problem hiding this comment.
I believe the copyright year in the license files
- LICENSE
- Modelica/Resources/Licenses/LICENSE_Modelica*.txt
also should get bumped.
beutlich
requested changes
Jan 10, 2024
beutlich
changed the title
henrikt-ma
reviewed
Jan 11, 2024
HansOlsson
reviewed
Jan 11, 2024
HansOlsson
reviewed
Jan 11, 2024
|
|
Contributor
|
@beutlich @HansOlsson @maltelenz @henrikt-ma can you please review the changes . Thankyou |
HansOlsson
reviewed
Jan 12, 2024
HansOlsson
requested changes
Jan 12, 2024
Contributor
HansOlsson
left a comment
HansOlsson
left a comment
There was a problem hiding this comment.
A number of minor changes have been requested.
Contributor
I think it would be good to first address the current comments, and then ask for a review. |
arunkumar-narasimhan
added a commit
to casella/ModelicaStandardLibrary
that referenced
this pull request
Jan 12, 2024
Removed version number as per comment modelica#4247 (comment)
arunkumar-narasimhan
added a commit
to casella/ModelicaStandardLibrary
that referenced
this pull request
Jan 12, 2024
arunkumar-narasimhan
added a commit
to casella/ModelicaStandardLibrary
that referenced
this pull request
Jan 12, 2024
Removed redundant version number info as per comment modelica#4247 (comment)
arunkumar-narasimhan
added a commit
to casella/ModelicaStandardLibrary
that referenced
this pull request
Jan 12, 2024
Dropped version number per comment in modelica#4247 (comment)
Contributor
|
@beutlich @HansOlsson @henrikt-ma @maltelenz we have addressed the changes mentioned , can you please go through the changes. Thankyou |
HansOlsson
reviewed
Jan 12, 2024
HansOlsson
approved these changes
Jan 12, 2024
Contributor
HansOlsson
left a comment
HansOlsson
left a comment
There was a problem hiding this comment.
Looks good.
Reverting the change for Mark, and deciding on dateModified isn't blocking
Co-authored-by: Hans Olsson <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Hans Olsson <[email protected]>
Co-authored-by: Hans Olsson <[email protected]>
beutlich
force-pushed
the
update-version
branch
from
5f27f93 to
7ba0448
Compare
Contributor
This was referenced Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all version and uses annotation to 4.1.0. It also updates copyright dates to 2024. Finally, it removes a spurious version annotation in a sub-package.