Skip to content

Conversation

@pcarleton
Copy link
Member

Motivation and Context

  • Add optional scope parameter to startAuthorization function signature
  • Include scope in authorization URL query parameters when provided
  • Update auth function to pass through scope from provider.clientMetadata
  • Add tests to verify scope is correctly included/excluded from auth URL

I ran into this while testing a python example server in the inspector

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

- Add optional scope parameter to startAuthorization function signature
- Include scope in authorization URL query parameters when provided
- Update auth function to pass through scope from provider.clientMetadata
- Add tests to verify scope is correctly included/excluded from auth URL

This enhancement allows clients to specify authorization scopes during the OAuth flow.
@pcarleton pcarleton marked this pull request as ready for review May 8, 2025 14:01
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ihrpr ihrpr merged commit bf7fd44 into modelcontextprotocol:main May 9, 2025
2 checks passed
Pizzaface pushed a commit to RewstApp/mcp-inspector that referenced this pull request Aug 20, 2025
…/revert-380-main

Revert "fix: handle the client disconnect so that the server does not crash."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants