Skip to content

fix(core): never send notifications/cancelled for the initialize hand… - #2668

Merged
felixweinberger merged 5 commits into
mainfrom
fix/no-cancel-notification-for-initialize
Aug 17, 2026
Merged

felixweinberger merged 5 commits into
mainfrom
fix/no-cancel-notification-for-initialize

Merge branch 'main' into fix/no-cancel-notification-for-initialize

c27adc2
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 17, 2026 in 10m 37s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/e2e/requirements.ts:146 [quality] nit: 'protocol:cancel:initialize-not-cancellable' still registers an [inMemory 2026-07-28] cell although the b

Annotations

Check warning on line 146 in test/e2e/requirements.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

[quality] nit: 'protocol:cancel:initialize-not-cancellable' still registers an [inMemory 2026-07-28] cell although the behavior is legacy-era-only — the entry lacks removedInSpecVersion: '2026-07-28' that sibling entry 'protocol:cancel:abort-signal' (li

[quality] nit: 'protocol:cancel:initialize-not-cancellable' still registers an [inMemory 2026-07-28] cell although the behavior is legacy-era-only — the entry lacks removedInSpecVersion: '2026-07-28' that sibling entry 'protocol:cancel:abort-signal' (line 132) uses for exactly this reason.