fix(validators): honor declared draft-07/06 JSON Schema dialects instead of rejecting them - #2534
Merged
Merged
Claude / Claude Code Review
completed
Jul 27, 2026 in 23m 35s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/core-internal/test/validators/validators.test.ts:806-808 |
Bypass tests became vacuous now that draft-07 is a supported dialect |
Annotations
Check warning on line 808 in packages/core-internal/test/validators/validators.test.ts
claude / Claude Code Review
Bypass tests became vacuous now that draft-07 is a supported dialect
The two escape-hatch tests here ('AJV: custom Ajv instance bypasses the $schema check' and 'CfWorker: explicit {draft} bypasses the $schema check') probe with a draft-07-stamped schema, but this PR makes draft-07 a supported dialect — so both tests now pass even if the bypass (`_userAjv` / `this.draft` short-circuit) is removed, since the default dispatch handles draft-07 identically without throwing. Probing with a still-rejected dialect (e.g. draft-04, as this PR already did for the analogous
Loading