feat(core): adopt spec#2907 error-code renumber; conformance referee → 0.2.0-alpha.5 - #2335
Merged
Merged
Claude / Claude Code Review
completed
Jun 23, 2026 in 19m 8s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/conformance/expected-failures.2026-07-28.yaml:18-21 |
Stale -32001 literal in waiver rationale contradicts the new alpha.5 NOTE in expected-failures.2026-07-28.yaml |
Annotations
Check warning on line 21 in test/conformance/expected-failures.2026-07-28.yaml
claude / Claude Code Review
Stale -32001 literal in waiver rationale contradicts the new alpha.5 NOTE in expected-failures.2026-07-28.yaml
The waiver rationale at lines 46-48 still says the 2026-mode mock rejects the MCP POST with `-32001`, but at the 0.2.0-alpha.5 referee this PR pins, that missing-MCP-Protocol-Version-header rejection is emitted as `-32020` (HeaderMismatch) — the alpha.5 dist contains no `-32001` — so the literal now contradicts the NOTE this same diff adds at lines 18-21. Comment-only: change `-32001` to `-32020` (or reword to "HeaderMismatch").
Loading