Repository navigation
feat(client,core): application_type client metadata with native/web inference (SEP-837) - #2266
Closed
mattzcarey wants to merge 5 commits into
Closed
mattzcarey wants to merge 5 commits into
mattzcarey wants to merge 5 commits into
Claude / Claude Code Review
completed
Jul 1, 2026 in 11m 59s
Code review found 1 important issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | .changeset/sep-837-application-type.md:11 |
Changeset/JSDoc describe application_type inference behavior the shipped code doesn't implement |
Annotations
Check failure on line 11 in .changeset/sep-837-application-type.md
claude / Claude Code Review
Changeset/JSDoc describe application_type inference behavior the shipped code doesn't implement
The changeset and the new JSDoc on `OAuthClientProvider.clientMetadata` describe an `application_type` inference the shipped code doesn't implement: the prose says `registerClient()` infers `'native'` when *every* redirect URI is an *HTTP* loopback URI, but the actual inference lives in `deriveApplicationType()`/`resolveClientMetadata()` (called only from `auth()`), returns `'native'` as soon as *any* redirect URI is loopback or custom-scheme, and also treats HTTPS loopback as native — the http-
Loading