Repository navigation
v2 backwards compat: SdkError status code - #2049
Merged
Merged
Claude / Claude Code Review
completed
May 15, 2026 in 12m 49s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/client/src/client/streamableHttp.ts:633-636 |
statusText accessor unpopulated at most SdkHttpError throw sites |
Annotations
Check warning on line 636 in packages/client/src/client/streamableHttp.ts
claude / Claude Code Review
statusText accessor unpopulated at most SdkHttpError throw sites
nit: `.statusText` is now a first-class typed accessor advertised in the changeset, JSDoc, and both migration docs (`console.log('Status text:', error.statusText)`), but 5 of the 7 `SdkHttpError` throw sites — including this catch-all `ClientHttpNotImplemented` path for every generic 4xx/5xx POST — pass `{ status, text }` or `{ status }` only and omit `statusText`, even though `response.statusText` is in scope on the same line. Same at `streamableHttp.ts:602` (`ClientHttpForbidden`) and the thre
Loading