Skip to content

refactor(client,server): move stdio transports to ./stdio subpath export - #1871

Merged
felixweinberger merged 10 commits into
mainfrom
fweinberger/browser-stdio-conditional-export
Apr 29, 2026
Merged

felixweinberger merged 10 commits into
mainfrom
fweinberger/browser-stdio-conditional-export

Merge branch 'main' into fweinberger/browser-stdio-conditional-export

a4a6100
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 15, 2026 in 6m 43s

Code review found 1 potential issue

Found 3 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit packages/server/src/index.ts:31-32 Stale comment in server index.ts: claims node:stream is a runtime dependency

Annotations

Check warning on line 32 in packages/server/src/index.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Stale comment in server index.ts: claims node:stream is a runtime dependency

This comment still says the subpath split keeps the root entry "free of process-stdio runtime dependencies (node:stream)", but server stdio only has a *type-level* `node:stream` import (erased at compile time) — `node:stream` was never a runtime dependency here. c2b85dbd fixed this exact wording in `src/stdio.ts` ("server stdio has only type-level Node imports") but missed this sibling comment, so the two now contradict each other.