Skip to content

feat(client): add reconnectionScheduler to StreamableHTTPClientTransport - #1763

Merged
felixweinberger merged 7 commits into
mainfrom
fweinberger/reconnection-scheduler
Mar 30, 2026
Merged

felixweinberger merged 7 commits into
mainfrom
fweinberger/reconnection-scheduler

Merge branch 'main' into fweinberger/reconnection-scheduler

d18c9b3
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Mar 27, 2026 in 8m 40s

Code review found 2 potential issues

Found 5 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit packages/client/src/client/streamableHttp.ts:96-102 Inline @example violates .examples.ts convention

Annotations

Check warning on line 102 in packages/client/src/client/streamableHttp.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Inline @example violates .examples.ts convention

Nit: The `@example` block on `ReconnectionScheduler` (lines 96–102) uses inline code, but [CLAUDE.md L46](../CLAUDE.md) requires JSDoc examples to reference companion `.examples.ts` files with `source="./streamableHttp.examples.ts#ReconnectionScheduler_basicUsage"`. All other files in this directory (`auth.ts`, `client.ts`, `middleware.ts`, `authExtensions.ts`) follow this convention.