-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Update Puppeteer (Code & README) #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Most of the changes look good, but I'm not sure about moving to a class. What are your thoughts?
src/puppeteer/index.ts
Outdated
| }, | ||
| ]; | ||
|
|
||
| class PuppeteerServer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this OO style is very conventional for TypeScript servers (if we look at Node.js' built-in HTTP, Express, the Slack SDK, etc).
Can we leave it as free functions?
…ahesh/update-puppeteer Update Puppeteer (Code & README)
Add mcp-server-rememberizer to community servers in README.md
…mberizer-server Add mcp-server-rememberizer to community servers in README.md
…ys-support Rc replays support
Update Puppeteer (Code & README)
No description provided.