Implementation of SEP-986: Specify Format for Tool Names #551
+270
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds validation for MCP tool naming conventions as specified in SEP-986. Ensures Rust SDK enforces standardized tool name formats, provides clear errors for invalid names, and improves consistency across implementations. Signed-off-by: tanish111 <[email protected]>
Update doctest examples to use the correct module path rmcp::handler::server::tool_name_validation instead of rmcp::model::tool_name_validation. Signed-off-by: tanish111 <[email protected]>
github-actions
bot
added
T-core
tanish111
changed the title
pbezglasny
reviewed
Nov 18, 2025
alexhancock
previously approved these changes
Nov 19, 2025
Contributor
alexhancock
left a comment
alexhancock
left a comment
There was a problem hiding this comment.
LGTM other than the one comment. I also prefer to remove most of the comments for code that is already clear.
| let result = validate_tool_name(name); | ||
|
|
||
| // Always issue warnings for any validation issues (both invalid names and warnings) | ||
| issue_tool_name_warning(name, &result.warnings); |
Contributor
There was a problem hiding this comment.
I would check if there are warnings here and only call the method if there are warnings as opposed to having that check internally
Contributor
Author
There was a problem hiding this comment.
@alexhancock I have updated the code with this suggestion.
(This would definitely save unnecessary stack calls)
Also I have remove most of comments just kept the one which are needed
Prevent empty warnings array from triggering warning output. Signed-off-by: tanish111 <[email protected]>
Signed-off-by: tanish111 <[email protected]>
Signed-off-by: tanish111 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
modelcontextprotocol/modelcontextprotocol/issues/986
How Has This Been Tested?
Manual testing in examples/servers: added name to existing #[tool] attributes in common/counter.rs with valid and invalid names. Rebuilding and running showed expected warnings. Unit tests (11) cover validation scenarios; integration tests are planned.
Breaking Changes
None, but console warnings may appear for SDK users who have names that do not satisfy the SEP.
Types of changes
Checklist
Additional context
All design decisions, names, and other aspects follow the TypeScript implementation for consistency across SDKs.
Related issue #518