Skip to content

fix: correct numeric types in progress notifications #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamadeo merged 2 commits into from
Aug 7, 2025
Merged

fix: correct numeric types in progress notifications #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe829bd
fix: correct numeric types in progress notifications
jamadeo Aug 7, 2025
fa1b885
fix: regenerate schemas
jamadeo Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/rmcp/src/model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,10 +758,10 @@ const_string!(ProgressNotificationMethod = "notifications/progress");
pub struct ProgressNotificationParam {
pub progress_token: ProgressToken,
/// The progress thus far. This should increase every time progress is made, even if the total is unknown.
pub progress: u32,
pub progress: f64,
/// Total number of items to process (or total progress required), if known
#[serde(skip_serializing_if = "Option::is_none")]
pub total: Option<u32>,
pub total: Option<f64>,
/// An optional message describing the current progress.
#[serde(skip_serializing_if = "Option::is_none")]
pub message: Option<String>,
Expand Down
10 changes: 4 additions & 6 deletions crates/rmcp/tests/test_message_schema/client_json_rpc_message_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,21 +762,19 @@
},
"progress": {
"description": "The progress thus far. This should increase every time progress is made, even if the total is unknown.",
"type": "integer",
"format": "uint32",
"minimum": 0
"type": "number",
"format": "double"
},
"progressToken": {
"$ref": "#/definitions/ProgressToken"
},
"total": {
"description": "Total number of items to process (or total progress required), if known",
"type": [
"integer",
"number",
"null"
],
"format": "uint32",
"minimum": 0
"format": "double"
}
},
"required": [
Expand Down
10 changes: 4 additions & 6 deletions crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,21 +1027,19 @@
},
"progress": {
"description": "The progress thus far. This should increase every time progress is made, even if the total is unknown.",
"type": "integer",
"format": "uint32",
"minimum": 0
"type": "number",
"format": "double"
},
"progressToken": {
"$ref": "#/definitions/ProgressToken"
},
"total": {
"description": "Total number of items to process (or total progress required), if known",
"type": [
"integer",
"number",
"null"
],
"format": "uint32",
"minimum": 0
"format": "double"
}
},
"required": [
Expand Down
10 changes: 4 additions & 6 deletions crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema_current.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,21 +1027,19 @@
},
"progress": {
"description": "The progress thus far. This should increase every time progress is made, even if the total is unknown.",
"type": "integer",
"format": "uint32",
"minimum": 0
"type": "number",
"format": "double"
},
"progressToken": {
"$ref": "#/definitions/ProgressToken"
},
"total": {
"description": "Total number of items to process (or total progress required), if known",
"type": [
"integer",
"number",
"null"
],
"format": "uint32",
"minimum": 0
"format": "double"
}
},
"required": [
Expand Down
4 changes: 2 additions & 2 deletions crates/rmcp/tests/test_progress_subscriber.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ impl MyServer {
let _ = client
.notify_progress(ProgressNotificationParam {
progress_token: progress_token.clone(),
progress: step,
total: Some(10),
progress: (step as f64),
total: Some(10.0),
message: Some("Some message".into()),
})
.await;
Expand Down