Document redirect_uri wire-format change in OAuth migration note - #2929
Merged
Merged
Claude / Claude Code Review
completed
Jun 20, 2026 in 10m 28s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | docs/migration.md:1262-1269 |
Migration note: 're-register the client' isn't actionable — clarify that the persisted client registration must be clear |
Annotations
Check warning on line 1269 in docs/migration.md
claude / Claude Code Review
Migration note: 're-register the client' isn't actionable — clarify that the persisted client registration must be cleared from TokenStorage
The instruction to "re-register the client" isn't actionable as written: the SDK only performs dynamic client registration when `TokenStorage.get_client_info()` returns nothing, so a persisted registration is reused as-is and there is no API to force re-registration. Suggest rewording to tell affected users to clear the stored client registration (and tokens) from their `TokenStorage` so the next flow registers afresh with the slash-less redirect URI.
Loading